From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: don't use printf!
Date: Wed, 9 Mar 2016 10:28:26 -0800
Message-ID: <20160309102826.2a1dcc7b@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 58D702B96
 for <dev@dpdk.org>; Wed,  9 Mar 2016 19:28:18 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id u190so17780364pfb.3
 for <dev@dpdk.org>; Wed, 09 Mar 2016 10:28:18 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id r68sm13973001pfa.33.2016.03.09.10.28.17
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 09 Mar 2016 10:28:17 -0800 (PST)
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

One thing I noticed while fixing mempool bug, was that there was a printf
in the library there. A reminder, code in DPDK library should never call printf
directly. printf in a real application is often ratholed off to /dev/null
and real output is through API's or syslog.

Offenders now:
 rte_mempool
 rte_acl
 rte_cfgfile

I would fix rte_acl but it would require API breakage.
rte_acl_dump should take a FILE *


Some places have printf in debug path, which is less bad, but
still limits usage of DEBUG options
 rte_sched
 rte_timer

There are also several places in the BSD support, but I care less about those.