All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
	"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
	Leonid Shatz <leonid.shatz@ravellosystems.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86/fpu: Revert earlier patch of Disable AVX when eagerfpu is off
Date: Wed, 9 Mar 2016 13:46:26 +0100	[thread overview]
Message-ID: <20160309124626.GA28660@gmail.com> (raw)
In-Reply-To: <1453511438-25827-1-git-send-email-yu-cheng.yu@intel.com>


* Yu-cheng Yu <yu-cheng.yu@intel.com> wrote:

> AVX was mistakenly believed to be dependent on eagerfpu switch.
> This turns out to be false. The earlier patch should be reverted.
> 
> Original patch:
>     http://git.kernel.org/tip/394db20ca240741a08d472173db13d6f6a6e5a28

So the original patch had a whole host of explanations of why that change is 
correct. This revert should explain where that argumentation was wrong.

Also note that eagerfpu=off is on the way out, on v4.6 we'll switch all CPUs to 
eagerfpu:

  58122bf1d856 x86/fpu: Default eagerfpu=on on all CPUs

and in the not so distant future, if everything goes fine with the eager mode, I'd 
like to drop the lazy FPU context switching code altogether - which will simplify 
a lot of code. At that point the 'eagerfpu' boot option will go away as well.

Thanks,

	Ingo

  reply	other threads:[~2016-03-09 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23  1:10 [PATCH] x86/fpu: Revert earlier patch of Disable AVX when eagerfpu is off Yu-cheng Yu
2016-03-09 12:46 ` Ingo Molnar [this message]
2016-03-09 17:19   ` Yu-cheng Yu
2016-03-09 18:42     ` Ingo Molnar
2016-03-09 18:51   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160309124626.GA28660@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=leonid.shatz@ravellosystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ravi.v.shankar@intel.com \
    --cc=sai.praneeth.prakhya@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.