From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v4 4/9] IB/core: refactor ib_create_qp Date: Wed, 9 Mar 2016 13:55:24 +0100 Message-ID: <20160309125524.GA31210@lst.de> References: <1457461000-24088-1-git-send-email-hch@lst.de> <1457461000-24088-5-git-send-email-hch@lst.de> <56DF2917.309@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56DF2917.309-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Christoph Hellwig , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Mar 08, 2016 at 11:33:43AM -0800, Bart Van Assche wrote: > My preference is to handle the "success" case first as in the original code: > > - if (!IS_ERR(qp)) > - __ib_insert_xrcd_qp(qp_init_attr->xrcd, real_qp); > - else > - real_qp->device->destroy_qp(real_qp); > > Even if this does not get addressed: > > Reviewed-by: Bart Van Assche I don't really care either way, so I've changed this. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html