From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: account for sparsemem section alignment when choosing vmemmap offset
Date: Wed, 9 Mar 2016 15:07:00 +0000 [thread overview]
Message-ID: <20160309150659.GE28496@arm.com> (raw)
In-Reply-To: <1457446169-23099-1-git-send-email-ard.biesheuvel@linaro.org>
On Tue, Mar 08, 2016 at 09:09:29PM +0700, Ard Biesheuvel wrote:
> Commit dfd55ad85e4a ("arm64: vmemmap: use virtual projection of linear
> region") fixed an issue where the struct page array would overflow into the
> adjacent virtual memory region if system RAM was placed so high up in
> physical memory that its addresses were not representable in the build time
> configured virtual address size.
>
> However, the fix failed to take into account that the vmemmap region needs
> to be relatively aligned with respect to the sparsemem section size, so that
> a sequence of page structs corresponding with a sparsemem section in the
> linear region appears naturally aligned in the vmemmap region.
>
> So round up vmemmap to sparsemem section size. Since this essentially moves
> the projection of the linear region up in memory, also revert the reduction
> of the size of the vmemmap region.
>
> Fixes: dfd55ad85e4a ("arm64: vmemmap: use virtual projection of linear region")
> Tested-by: Mark Langsdorf <mlangsdo@redhat.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm64/include/asm/pgtable.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Sorry for the slight delay, I was flying back from the US and didn't
read mail for a couple of days. Anyway, I'll send this for 4.5 along
with a CC stable and the various tested-bys. Hopefully it won't be too
late for final.
Will
prev parent reply other threads:[~2016-03-09 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 14:09 [PATCH] arm64: account for sparsemem section alignment when choosing vmemmap offset Ard Biesheuvel
2016-03-08 14:18 ` Greg KH
2016-03-08 14:21 ` Ard Biesheuvel
2016-03-08 15:12 ` Catalin Marinas
2016-03-09 1:19 ` Ard Biesheuvel
2016-03-09 11:54 ` Catalin Marinas
2016-03-08 20:08 ` David Daney
2016-03-09 15:07 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309150659.GE28496@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.