From: Olaf Hering <olaf@aepfle.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] bogus bdrv_check_request in bdrv_co_discard
Date: Wed, 9 Mar 2016 17:50:26 +0100 [thread overview]
Message-ID: <20160309165026.GA14059@aepfle.de> (raw)
In-Reply-To: <20160309145837.GI5205@noname.redhat.com>
On Wed, Mar 09, Kevin Wolf wrote:
> Removing integer overflow checks without removing the potentially
> overflowing operation doesn't feel like a particularly good idea,
> though.
Why does the code use signed ints anyway for sectors and offset?!
Olaf
next prev parent reply other threads:[~2016-03-09 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 12:11 [Qemu-devel] bogus bdrv_check_request in bdrv_co_discard Olaf Hering
2016-03-09 12:29 ` Paolo Bonzini
[not found] ` <20160309144514.GA29027@aepfle.de>
2016-03-09 14:58 ` Kevin Wolf
2016-03-09 16:50 ` Olaf Hering [this message]
2016-03-09 17:03 ` Olaf Hering
2016-03-16 10:18 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309165026.GA14059@aepfle.de \
--to=olaf@aepfle.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.