From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, guaneryu@gmail.com
Subject: Re: regression in 4.5-rc5 - generic/324 failure
Date: Wed, 9 Mar 2016 18:19:49 -0500 [thread overview]
Message-ID: <20160309231949.GC3949@thunk.org> (raw)
In-Reply-To: <20160309221746.GA1763@localhost.localdomain>
On Wed, Mar 09, 2016 at 05:17:46PM -0500, Eric Whitney wrote:
> I'm seeing generic/324 fail consistently when run with xfstest-bld's test
> appliance in the 1k block size test case on x86_64. This happened first on my
> 4.5-rc5 regression run, and it repeated on -rc6 and -rc7.
>
> Reverting a commit introduced in 4.5-rc5 inhibits the failure:
> "ext4: don't read blocks from disk after extents being swapped" (bcff24887d00)
Yeah, sorry, I didn't recognize the failure you described on the
phone. This has been fixed in the ext4 dev tree:
commit 87f9a031af48defee9f34c6aaf06d6f1988c244d
Author: Eryu Guan <guaneryu@gmail.com>
Date: Sun Feb 21 18:38:44 2016 -0500
ext4: iterate over buffer heads correctly in move_extent_per_page()
In commit bcff24887d00 ("ext4: don't read blocks from disk after extents
being swapped") bh is not updated correctly in the for loop and wrong
data has been written to disk. generic/324 catches this on sub-page
block size ext4.
Fixes: bcff24887d00 ("ext4: don't read blocks from disk after extentsbeing swapped")
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
I should have realized this was a 4.5 regression that should have been
pushed to Linus directly. It's awfully late, and I'm not sure there's
going to be a -rc8, but I'll see if I can get this to Linus this cycle
or not.
- Ted
prev parent reply other threads:[~2016-03-09 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 22:17 regression in 4.5-rc5 - generic/324 failure Eric Whitney
2016-03-09 23:19 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309231949.GC3949@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.