From: Peter Xu <peterx@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] block/qapi: make two printf() formats literal
Date: Thu, 10 Mar 2016 09:46:25 +0800 [thread overview]
Message-ID: <20160310014625.GE4091@pxdev.xzpeter.org> (raw)
In-Reply-To: <56E0A02B.50102@redhat.com>
On Wed, Mar 09, 2016 at 03:14:03PM -0700, Eric Blake wrote:
> > + func_fprintf(f, "%*s[%i]:%c", indentation * 4, "", i,
> > + composite ? '\n' : ' ');
>
> [The nerd in me wants to point out that you could avoid the ternary by
> writing '"\n "[composite]', but that's too ugly to use outside of IOCCC
> submissions, and I wouldn't be surprised if it (rightfully) triggers
> clang warnings]
Do you mean something like:
int i = 0;
printf("%c", '"\n "[i]');
Is this a grammar btw?
Peter
next prev parent reply other threads:[~2016-03-10 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 5:56 [Qemu-devel] [PATCH 0/2] block/qapi: trivial fixes Peter Xu
2016-03-09 5:56 ` [Qemu-devel] [PATCH 1/2] block/qapi: make two printf() formats literal Peter Xu
2016-03-09 22:14 ` Eric Blake
2016-03-10 1:46 ` Peter Xu [this message]
2016-03-21 21:14 ` Eric Blake
2016-03-22 2:04 ` Peter Xu
2016-03-22 15:47 ` Markus Armbruster
2016-03-09 5:56 ` [Qemu-devel] [PATCH 2/2] block/qapi: fix unbounded stack for dump_qdict Peter Xu
2016-03-09 22:16 ` Eric Blake
2016-03-22 15:48 ` Markus Armbruster
2016-03-22 15:50 ` [Qemu-devel] [PATCH 0/2] block/qapi: trivial fixes Markus Armbruster
2016-03-22 16:27 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310014625.GE4091@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.