From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver Date: Thu, 10 Mar 2016 10:58:30 +0300 Message-ID: <20160310075830.GB5273@mwanda> References: <1457451209-21462-1-git-send-email-okaya@codeaurora.org> <56DEF1BE.8010701@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56DEF1BE.8010701-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sinan Kaya Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, vikrams-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Baptiste Reynal , Alex Williamson , Arnd Bergmann , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Tue, Mar 08, 2016 at 10:37:34AM -0500, Sinan Kaya wrote: > On 3/8/2016 10:33 AM, Sinan Kaya wrote: > > + int rc = 0; > > + > > I should have initialized this to -1. > -1 is a magic number which stands for -EPERM which is wrong. Use -ENODEV. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Thu, 10 Mar 2016 10:58:30 +0300 Subject: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver In-Reply-To: <56DEF1BE.8010701@codeaurora.org> References: <1457451209-21462-1-git-send-email-okaya@codeaurora.org> <56DEF1BE.8010701@codeaurora.org> Message-ID: <20160310075830.GB5273@mwanda> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 08, 2016 at 10:37:34AM -0500, Sinan Kaya wrote: > On 3/8/2016 10:33 AM, Sinan Kaya wrote: > > + int rc = 0; > > + > > I should have initialized this to -1. > -1 is a magic number which stands for -EPERM which is wrong. Use -ENODEV. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754488AbcCJH7f (ORCPT ); Thu, 10 Mar 2016 02:59:35 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:36984 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753463AbcCJH71 (ORCPT ); Thu, 10 Mar 2016 02:59:27 -0500 Date: Thu, 10 Mar 2016 10:58:30 +0300 From: Dan Carpenter To: Sinan Kaya Cc: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org, shankerd@codeaurora.org, vikrams@codeaurora.org, marc.zyngier@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, vinod.koul@intel.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , Alex Williamson , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] vfio, platform: add support for ACPI while detecting the reset driver Message-ID: <20160310075830.GB5273@mwanda> References: <1457451209-21462-1-git-send-email-okaya@codeaurora.org> <56DEF1BE.8010701@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56DEF1BE.8010701@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 08, 2016 at 10:37:34AM -0500, Sinan Kaya wrote: > On 3/8/2016 10:33 AM, Sinan Kaya wrote: > > + int rc = 0; > > + > > I should have initialized this to -1. > -1 is a magic number which stands for -EPERM which is wrong. Use -ENODEV. regards, dan carpenter