From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adx4m-0004zn-9e for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:40:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adx4i-00033z-JB for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:40:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adx4i-00033v-EL for qemu-devel@nongnu.org; Thu, 10 Mar 2016 04:40:08 -0500 Date: Thu, 10 Mar 2016 09:40:04 +0000 From: "Daniel P. Berrange" Message-ID: <20160310094004.GC25607@redhat.com> References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-22-git-send-email-berrange@redhat.com> <87io0uu2ye.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87io0uu2ye.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v1 21/21] error: ensure errno detail is printed with error_abort Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , qemu-devel@nongnu.org, Andrew Baumann , Stefan Weil On Thu, Mar 10, 2016 at 09:55:37AM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > When &error_abort is passed in, the error reporting code > > will print the current error message and then abort() the > > process. Unfortunately at the time it aborts, we've not > > yet appended the errno detail. This makes debugging certain > > problems significantly harder as the log is incomplete. > > > > Signed-off-by: Daniel P. Berrange > > Reviewed-by: Markus Armbruster > > I can take this through my tree, but it's perhaps easier to let it flow > along with the rest of your series. Nah, it isn't critical to the rest of this series. Its just tacked on as I noticed it while debugging tests, so you might as well just take it through your tree as normal. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|