From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/kms_rotation_crc: exercise invalid rotations
Date: Thu, 10 Mar 2016 12:38:51 +0200 [thread overview]
Message-ID: <20160310103851.GB10446@intel.com> (raw)
In-Reply-To: <CAM0jSHMY_kzeJKUPwcwexAoKFLwn7X5m1vEV1UfJ=UAcHpwrng@mail.gmail.com>
On Thu, Mar 10, 2016 at 09:03:37AM +0000, Matthew Auld wrote:
> > Y tiled fb will be rejected for gen < 9, should use X/linear for those.
>
> Are you referring to the __gem_set_tiling call? Since this didn't fail
> on BDW and I don't see any logic in i915_gem_set_tiling which
> implements this.
No, I mean the addfb. Note that the current logic in addfb is sort of
silly, and I tried to fix it in
https://lists.freedesktop.org/archives/intel-gfx/2016-February/087670.html
but no review so far.
>
> > Actually using X/linear for gen >= 9 would also be interesting to
> make sure we reject 90/270
>
> Yup, good point
>
> > I would suggest looking at the supported rotations for each plane
> and picking some invalid ones based on that.
>
> Sorry, I must be missing something, isn't that what it already does?
> I've just picked the invalid rotations for the primary, cursor and sprite
> planes.
I mean that instead of hardcoding the assumption which rotation are
unsupported, you could actually look at what the driver reports as
supported vs. not.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-03-10 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 15:05 [PATCH i-g-t] igt/kms_rotation_crc: exercise invalid rotations Matthew Auld
2016-03-09 15:25 ` Ville Syrjälä
2016-03-10 9:03 ` Matthew Auld
2016-03-10 10:38 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310103851.GB10446@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.