From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 5/7] perf, tools, stat: Implement --metric-only mode
Date: Thu, 10 Mar 2016 12:28:35 +0100 [thread overview]
Message-ID: <20160310112835.GA2617@krava.redhat.com> (raw)
In-Reply-To: <1457049458-28956-6-git-send-email-andi@firstfloor.org>
On Thu, Mar 03, 2016 at 03:57:36PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Add a new mode to only print metrics. Sometimes we don't care about
> the raw values, just want the computed metrics. This allows more
> compact printing, so with -I each sample is only a single line.
> This also allows easier plotting and processing with other tools.
>
> The main target is with using --topdown, but it also works with
> -T and standard perf stat. A few metrics are not supported.
>
> To avoiding having to hardcode all the metrics in the code it uses
> a two pass approach: first compute dummy metrics and only
> print the headers in the print_metric callback. Then use the callback
> to print the actual values.
>
> There are some additional changes
> in the stat printout code to handle all metrics being on a single line.
>
> One issue is that the column code doesn't know in advance what events
> are not supported by the CPU, and it would be hard to find out
> as this could change based on dynamic conditions. That causes
> empty columns in some cases.
>
> The output can be fairly wide, often you may need more than 80 columns.
>
> Example:
>
> % perf stat -a -I 1000 --metric-only
> 1.001452803 frontend cycles idle insn per cycle stalled cycles per insn branch-misses of all branches
> 1.001452803 158.91% 0.66 2.39 2.92%
> 2.002192321 180.63% 0.76 2.08 2.96%
> 3.003088282 150.59% 0.62 2.57 2.84%
> 4.004369835 196.20% 0.98 1.62 3.79%
> 5.005227314 231.98% 0.84 1.90 4.71%
could you please also make a change to display some kind of warning
if there're no events to produce any metrics?
[jolsa@krava perf]$ sudo ./perf stat -a -I 1000 --metric-only -e cycles
1.000172990
1.000172990
2.000448614
this could be follow up patch
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2016-03-10 11:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 23:57 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-03 23:57 ` [PATCH 1/7] perf, tools, stat: Check existence of frontend/backed stalled cycles Andi Kleen
2016-03-03 23:57 ` [PATCH 2/7] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-03-03 23:57 ` [PATCH 3/7] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-03-03 23:57 ` [PATCH 4/7] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-03-10 11:29 ` Jiri Olsa
2016-03-11 8:52 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-03 23:57 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-10 11:28 ` Jiri Olsa [this message]
2016-03-11 8:52 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-03 23:57 ` [PATCH 6/7] perf, tools, stat: Add --metric-only support for -A Andi Kleen
2016-03-10 11:32 ` Jiri Olsa
2016-03-11 8:52 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-03 23:57 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Andi Kleen
2016-03-07 10:08 ` perf, tools: Refactor and support interval and CSV metrics Jiri Olsa
2016-03-07 18:22 ` Andi Kleen
2016-03-07 18:48 ` Jiri Olsa
2016-03-07 21:11 ` Andi Kleen
2016-03-10 11:34 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2016-03-03 0:24 Andi Kleen
2016-03-03 0:24 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-01 18:57 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-01 18:57 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-02 11:57 ` Jiri Olsa
2016-03-02 15:35 ` Andi Kleen
2016-02-29 22:36 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-02-29 22:36 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-03-01 14:53 ` Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-03-01 18:51 ` Andi Kleen
2016-03-02 11:28 ` Jiri Olsa
2016-03-02 15:38 ` Andi Kleen
2016-03-02 15:46 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310112835.GA2617@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.