From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Exit cherryview_irq_handler() after one pass Date: Thu, 10 Mar 2016 14:24:39 +0200 Message-ID: <20160310122439.GF10446@intel.com> References: <1457610268-25299-1-git-send-email-chris@chris-wilson.co.uk> <20160310120127.GD10446@intel.com> <20160310121046.GN1405@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 80B586E95F for ; Thu, 10 Mar 2016 12:24:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160310121046.GN1405@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Antti =?iso-8859-1?Q?Koskip=E4=E4?= , Tvrtko Ursulin , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMTAsIDIwMTYgYXQgMTI6MTA6NDZQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgTWFyIDEwLCAyMDE2IGF0IDAyOjAxOjI3UE0gKzAyMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+IE9uIFRodSwgTWFyIDEwLCAyMDE2IGF0IDExOjQ0OjI4QU0gKzAw MDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+ID4gVGhpcyBlZmZlY3RpdmVseSByZXZlcnRzCj4g PiA+IAo+ID4gPiBjb21taXQgOGU1ZmQ1OTllYjIxOWYxMDU0ZTM5YjQwZDE4YjIxN2FmNjY5ZWVh OQo+ID4gPiBBdXRob3I6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gPiA+IERhdGU6ICAgV2VkIEFwciA5IDEzOjI4OjUwIDIwMTQgKzAzMDAKPiA+ID4g Cj4gPiA+ICAgICBkcm0vaTkxNS9jaHY6IE1ha2UgQ0hWIGlycSBoYW5kbGVyIGxvb3AgdW50aWwg YWxsIGludGVycnVwdHMgYXJlIGNvbnN1bWVkCj4gPiA+IAo+ID4gPiBhcyB1bmRlciBjb250aW51 b3VzIGV4ZWNsaXN0cyBsb2FkIHdlIGNhbiBzYXR1cmF0ZSB0aGUgSVJRIGhhbmRsZXIsCj4gPiA+ IGRlc3RhYmxpc2luZyB0aGUgdHNjIGNsb2NrIGFuZCB0cmlnZ2VyaW5nIHRoZSBOTUkgd2F0Y2hk b2cgdG8gZGVjbGFyZSBhIGh1bmcKPiA+ID4gQ1BVLgo+ID4gPiAKPiA+ID4gWyAgNTUyLjc1NjA1 MV0gY2xvY2tzb3VyY2U6IHRpbWVrZWVwaW5nIHdhdGNoZG9nIG9uIENQVTA6IE1hcmtpbmcgY2xv Y2tzb3VyY2UgJ3RzYycgYXMgdW5zdGFibGUgYmVjYXVzZSB0aGUgc2tldyBpcyB0b28gbGFyZ2U6 Cj4gPiA+IFsgIDU1Mi43NTYwODBdIGNsb2Nrc291cmNlOiAgICAgICAgICAgICAgICAgICAgICAg J3JlZmluZWQtamlmZmllcycgd2Rfbm93OiAxMDAwM2I0ODAgd2RfbGFzdDogMTAwMDNiMjhjIG1h c2s6IGZmZmZmZmZmCj4gPiA+IFsgIDU1Mi43NTYwOTFdIGNsb2Nrc291cmNlOiAgICAgICAgICAg ICAgICAgICAgICAgJ3RzYycgY3Nfbm93OiBkNTVkMzFhYTUwIGNzX2xhc3Q6IGQxNzQ0NjE2NmMg bWFzazogZmZmZmZmZmZmZmZmZmZmZgo+ID4gPiBbICA1NTIuNzU2MjEwXSBjbG9ja3NvdXJjZTog U3dpdGNoZWQgdG8gY2xvY2tzb3VyY2UgcmVmaW5lZC1qaWZmaWVzCj4gPiA+IFsgIDU3NS4yMTc4 NzBdIE5NSSB3YXRjaGRvZzogV2F0Y2hkb2cgZGV0ZWN0ZWQgaGFyZCBMT0NLVVAgb24gY3B1IDEK PiA+ID4gWyAgNTc1LjIxNzg5M10gQ1BVOiAxIFBJRDogMCBDb21tOiBzd2FwcGVyLzEgTm90IHRh aW50ZWQgNC41LjAtcmM3KyAjMTgKPiA+ID4gWyAgNTc1LjIxNzkwNV0gSGFyZHdhcmUgbmFtZTog ICAgICAgICAgICAgICAgICAvTlVDNUNQWUIsIEJJT1MgUFlCU1dDRUwuODZBLjAwMjcuMjAxNS4w NTA3LjE3NTggMDUvMDcvMjAxNQo+ID4gPiBbICA1NzUuMjE3OTE1XSAgMDAwMDAwMDAwMDAwMDAw MCBmZmZmODgwMjdmZDA1YmMwIGZmZmZmZmZmODEyODhjNmQgMDAwMDAwMDAwMDAwMDAwMAo+ID4g PiBbICA1NzUuMjE3OTM1XSAgMDAwMDAwMDAwMDAwMDAwMSBmZmZmODgwMjdmZDA1YmUwIGZmZmZm ZmZmODEwZTcyZDEgMDAwMDAwMDAwMDAwMDAwMAo+ID4gPiBbICA1NzUuMjE3OTUxXSAgZmZmZjg4 MDI3ZmQwNWM4MCBmZmZmODgwMjdmZDA1YzIwIGZmZmZmZmZmODExMTRiNjAgMDAwMDAwMDE4MTAx NWYxZQo+ID4gPiBbICA1NzUuMjE3OTY3XSBDYWxsIFRyYWNlOgo+ID4gPiBbICA1NzUuMjE3OTcz XSAgPE5NST4gIFs8ZmZmZmZmZmY4MTI4OGM2ZD5dIGR1bXBfc3RhY2srMHg0Zi8weDcyCj4gPiA+ IFsgIDU3NS4yMTc5OTRdICBbPGZmZmZmZmZmODEwZTcyZDE+XSB3YXRjaGRvZ19vdmVyZmxvd19j YWxsYmFjaysweDE1MS8weDE2MAo+ID4gPiBbICA1NzUuMjE4MDAzXSAgWzxmZmZmZmZmZjgxMTE0 YjYwPl0gX19wZXJmX2V2ZW50X292ZXJmbG93KzB4YTAvMHgxZTAKPiA+ID4gWyAgNTc1LjIxODAx Nl0gIFs8ZmZmZmZmZmY4MTExNTRjND5dIHBlcmZfZXZlbnRfb3ZlcmZsb3crMHgxNC8weDIwCj4g PiA+IFsgIDU3NS4yMTgwMjhdICBbPGZmZmZmZmZmODEwMWQyY2E+XSBpbnRlbF9wbXVfaGFuZGxl X2lycSsweDFkYS8weDQ2MAo+ID4gPiBbICA1NzUuMjE4MDQyXSAgWzxmZmZmZmZmZjgxNGE4YWFl Pl0gPyBwb2xsX2lkbGUrMHgzZS8weDcwCj4gPiA+IFsgIDU3NS4yMTgwNTJdICBbPGZmZmZmZmZm ODE0YThhYWU+XSA/IHBvbGxfaWRsZSsweDNlLzB4NzAKPiA+ID4gWyAgNTc1LjIxODA2NF0gIFs8 ZmZmZmZmZmY4MTAxNGFlOD5dIHBlcmZfZXZlbnRfbm1pX2hhbmRsZXIrMHgyOC8weDUwCj4gPiA+ IFsgIDU3NS4yMTgwNzVdICBbPGZmZmZmZmZmODEwMDc1NDA+XSBubWlfaGFuZGxlKzB4NjAvMHgx MzAKPiA+ID4gWyAgNTc1LjIxODA4Nl0gIFs8ZmZmZmZmZmY4MTRhOGFhZT5dID8gcG9sbF9pZGxl KzB4M2UvMHg3MAo+ID4gPiBbICA1NzUuMjE4MDk2XSAgWzxmZmZmZmZmZjgxMDA3OWMwPl0gZG9f bm1pKzB4MTQwLzB4NDcwCj4gPiA+IFsgIDU3NS4yMTgxMDhdICBbPGZmZmZmZmZmODE1NTllYzc+ XSBlbmRfcmVwZWF0X25taSsweDFhLzB4MWUKPiA+ID4gWyAgNTc1LjIxODExOV0gIFs8ZmZmZmZm ZmY4MTRhOGFhZT5dID8gcG9sbF9pZGxlKzB4M2UvMHg3MAo+ID4gPiBbICA1NzUuMjE4MTI5XSAg WzxmZmZmZmZmZjgxNGE4YWFlPl0gPyBwb2xsX2lkbGUrMHgzZS8weDcwCj4gPiA+IFsgIDU3NS4y MTgxMzldICBbPGZmZmZmZmZmODE0YThhYWU+XSA/IHBvbGxfaWRsZSsweDNlLzB4NzAKPiA+ID4g WyAgNTc1LjIxODE0OF0gIDw8RU9FPj4gIFs8ZmZmZmZmZmY4MTRhODM1Mz5dIGNwdWlkbGVfZW50 ZXJfc3RhdGUrMHhmMy8weDJmMAo+ID4gPiBbICA1NzUuMjE4MTY0XSAgWzxmZmZmZmZmZjgxNGE4 NTg3Pl0gY3B1aWRsZV9lbnRlcisweDE3LzB4MjAKPiA+ID4gWyAgNTc1LjIxODE3NV0gIFs8ZmZm ZmZmZmY4MTBhYWEzYT5dIGNhbGxfY3B1aWRsZSsweDJhLzB4NDAKPiA+ID4gWyAgNTc1LjIxODE4 NV0gIFs8ZmZmZmZmZmY4MTBhYWRlMz5dIGNwdV9zdGFydHVwX2VudHJ5KzB4MjczLzB4MzMwCj4g PiA+IFsgIDU3NS4yMTgxOTZdICBbPGZmZmZmZmZmODEwMzNhMWU+XSBzdGFydF9zZWNvbmRhcnkr MHgxMGUvMHgxMzAKPiA+ID4gCj4gPiA+IEhvd2V2ZXIsIG5vdCBzZXJ2aWNpbmcgYWxsIGF2YWls YWJsZSBJSVIgd2l0aGluIHRoZSBoYW5kbGVyIGRvZXMgaHVydCB0aGUKPiA+ID4gdGhyb3VnaHB1 dCBvZiBwYXRob2xvZ2ljYWwgbm9wIGV4ZWNidWYgYnkgYWJvdXQgMjAlLCB3aXRoIGEgc2ltaWxh ciBlZmZlY3QKPiA+ID4gdXBvbiB0aGUgZGlzcGF0Y2ggbGF0ZW5jeSBvZiBhIHNlcmllcyBvZiBl eGVjYnVmLgo+ID4gPiAKPiA+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5v cmcvc2hvd19idWcuY2dpP2lkPTkzNDY3Cj4gPiA+IFRlc3RjYXNlOiBpZ3QvZ2VtX2V4ZWNfbm9w L2Jhc2ljICMgcmVxdWlyZXMgTk1JIHdhdGNoZG9nCj4gPiA+IFNpZ25lZC1vZmYtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gPiBDYzogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQ2M6IEFudHRpIEtvc2tp cMOkw6QgPGFudHRpLmtvc2tpcGFhQGxpbnV4LmludGVsLmNvbQo+ID4gPiBDYzogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiA+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtl cm5lbC5vcmcKPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5j IHwgNDAgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgMSBm aWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiA+IGluZGV4IDUzZTUxMDQ5NjRiMy4uOGEzMjMw NDI3ODg0IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ID4gQEAgLTE4 MjksMzUgKzE4MjksMzMgQEAgc3RhdGljIGlycXJldHVybl90IGNoZXJyeXZpZXdfaXJxX2hhbmRs ZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ID4gPiAgCS8qIElSUXMgYXJlIHN5bmNlZCBkdXJpbmcg cnVudGltZV9zdXNwZW5kLCB3ZSBkb24ndCByZXF1aXJlIGEgd2FrZXJlZiAqLwo+ID4gPiAgCWRp c2FibGVfcnBtX3dha2VyZWZfYXNzZXJ0cyhkZXZfcHJpdik7Cj4gPiA+ICAKPiA+ID4gLQlmb3Ig KDs7KSB7Cj4gPiA+IC0JCW1hc3Rlcl9jdGwgPSBJOTE1X1JFQUQoR0VOOF9NQVNURVJfSVJRKSAm IH5HRU44X01BU1RFUl9JUlFfQ09OVFJPTDsKPiA+ID4gLQkJaWlyID0gSTkxNV9SRUFEKFZMVl9J SVIpOwo+ID4gPiArCW1hc3Rlcl9jdGwgPSBJOTE1X1JFQUQoR0VOOF9NQVNURVJfSVJRKSAmIH5H RU44X01BU1RFUl9JUlFfQ09OVFJPTDsKPiA+ID4gKwlpaXIgPSBJOTE1X1JFQUQoVkxWX0lJUik7 Cj4gPiA+ICAKPiA+ID4gLQkJaWYgKG1hc3Rlcl9jdGwgPT0gMCAmJiBpaXIgPT0gMCkKPiA+ID4g LQkJCWJyZWFrOwo+ID4gPiArCWlmIChtYXN0ZXJfY3RsID09IDAgJiYgaWlyID09IDApCj4gPiA+ ICsJCWJyZWFrOwo+ID4gCj4gPiBnb3RvIHNvbWV0aGluZz8KPiAKPiBTaWdoLiBUaGUgcHJvYmxl bSBvZiByZXdyaXRpbmcgdGhlICJvYnZpb3VzIiBwYXRjaCBhZ2FpbnN0IC1uaWdodGx5LiBJCj4g anVzdCBjaGFuZ2VkIHRoZSBmb3IoOzspIGludG8gZG8ge30gd2hpbGUoMCkgZm9yIHRlc3Rpbmcu IFBlcmhhcHMgSQo+IHNob3VsZCBzdGljayB3aXRoIHRoYXQgaW4gY2FzZSB3ZSBuZWVkIHRvIGZs aXAgZmxvcCBhZ2luLgo+IAo+ID4gQXBhcnQgZnJvbSB0aGF0IEkgaGF2ZSBubyBvYmplY3Rpb25z IGlmIGl0IGRvZXNuJ3QgY2F1c2UgcHJvYmxlbXMKPiA+IHdpdGggaW50ZXJydXB0cyBnZXR0aW5n IGxvc3QgYW5kIHdoYXRub3QuIFRoYXQgd2FzIHRoZSBvcmlnaW5hbCByZWFzb24KPiA+IGZvciBp dCBJIHRoaW5rLCBidXQgYXQgbGVhc3QgSSBteXNlbGYgbmV2ZXIgcmVhbGx5IGxvb2tlZCBpbnRv IGl0LiBJSVJDCj4gPiBSYWZhZWwganVzdCB0b2xkIG1lIHRoZXkgbmVlZGVkIHRvIGRvIGl0IHRv IGdldCB0aGUgdGhpbmcgd29ya2luZywgc28KPiA+IEkganVzdCBwdXQgdGhlIHBhdGNoIGluLiBB bmQgdGhhdCB3YXMgYmVmb3JlIEkgaGFkIGV2ZW4gc2VlbiBhbnkgc2lsaWNvbi4KPiAKPiBNeSB0 ZXN0aW5nIG9ubHkgbG9va3MgYXQgdGhlIEdUIHNpZGUsIGFuZCB3ZSBkbyBzdHJlc3MgdGhhdCBw cmV0dHkgaGFyZAo+IGJlY2F1c2Ugb2YgZXhlY2xpc3RzIGFuZCBoYXZlIHJlYXNvbmFibGUgbWV0 aG9kcyBvZiBkZXRlY3Rpb24gaWYgd2Ugc3RvcAo+IHByb2Nlc3NpbmcgZXhlY2J1Zi4gSSdtIG1v cmUgd29ycmllZCBhYm91dCB0aGUgZGlzcGxheSBhbmQgcGlwZSBpbnRlcnJ1cHRzLgoKSUlSQyBH VCB3YXMgd2hlcmUgdGhlIHByb2JsZW0gd2FzIG9yaWdpbmFsbHkuCgpBbmQganVzdCBhcyBhIHNp ZGUgbm90ZSwgSSBkbyBoYXZlIGEgYnJhbmNoIHNvbWV3aGVyZSB0aGF0IHJld3JpdGVzIGFsbAp0 aGUgZ21jaCBpcnEgaGFuZGxlcnMgdG8gbm90IGxvb3AuIEp1c3QgbmV2ZXIgYWN0dWFsbHkgZm91 bmQgdGhlIHRpbWUgdG8KcmVhbGx5IHJ1biBpdCBvbiBhbnl0aGluZyA6KSBTbyBJIGxpa2UgbW92 aW5nIHRvd2FyZHMgdGhhdCBkaXJlY3Rpb24gaW4KYW55IGNhc2UuCgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:18920 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbcCJMY5 (ORCPT ); Thu, 10 Mar 2016 07:24:57 -0500 Date: Thu, 10 Mar 2016 14:24:39 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson , intel-gfx@lists.freedesktop.org, Antti =?iso-8859-1?Q?Koskip=E4=E4?= , Tvrtko Ursulin , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Exit cherryview_irq_handler() after one pass Message-ID: <20160310122439.GF10446@intel.com> References: <1457610268-25299-1-git-send-email-chris@chris-wilson.co.uk> <20160310120127.GD10446@intel.com> <20160310121046.GN1405@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160310121046.GN1405@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Mar 10, 2016 at 12:10:46PM +0000, Chris Wilson wrote: > On Thu, Mar 10, 2016 at 02:01:27PM +0200, Ville Syrj�l� wrote: > > On Thu, Mar 10, 2016 at 11:44:28AM +0000, Chris Wilson wrote: > > > This effectively reverts > > > > > > commit 8e5fd599eb219f1054e39b40d18b217af669eea9 > > > Author: Ville Syrj�l� > > > Date: Wed Apr 9 13:28:50 2014 +0300 > > > > > > drm/i915/chv: Make CHV irq handler loop until all interrupts are consumed > > > > > > as under continuous execlists load we can saturate the IRQ handler, > > > destablising the tsc clock and triggering the NMI watchdog to declare a hung > > > CPU. > > > > > > [ 552.756051] clocksource: timekeeping watchdog on CPU0: Marking clocksource 'tsc' as unstable because the skew is too large: > > > [ 552.756080] clocksource: 'refined-jiffies' wd_now: 10003b480 wd_last: 10003b28c mask: ffffffff > > > [ 552.756091] clocksource: 'tsc' cs_now: d55d31aa50 cs_last: d17446166c mask: ffffffffffffffff > > > [ 552.756210] clocksource: Switched to clocksource refined-jiffies > > > [ 575.217870] NMI watchdog: Watchdog detected hard LOCKUP on cpu 1 > > > [ 575.217893] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.5.0-rc7+ #18 > > > [ 575.217905] Hardware name: /NUC5CPYB, BIOS PYBSWCEL.86A.0027.2015.0507.1758 05/07/2015 > > > [ 575.217915] 0000000000000000 ffff88027fd05bc0 ffffffff81288c6d 0000000000000000 > > > [ 575.217935] 0000000000000001 ffff88027fd05be0 ffffffff810e72d1 0000000000000000 > > > [ 575.217951] ffff88027fd05c80 ffff88027fd05c20 ffffffff81114b60 0000000181015f1e > > > [ 575.217967] Call Trace: > > > [ 575.217973] [] dump_stack+0x4f/0x72 > > > [ 575.217994] [] watchdog_overflow_callback+0x151/0x160 > > > [ 575.218003] [] __perf_event_overflow+0xa0/0x1e0 > > > [ 575.218016] [] perf_event_overflow+0x14/0x20 > > > [ 575.218028] [] intel_pmu_handle_irq+0x1da/0x460 > > > [ 575.218042] [] ? poll_idle+0x3e/0x70 > > > [ 575.218052] [] ? poll_idle+0x3e/0x70 > > > [ 575.218064] [] perf_event_nmi_handler+0x28/0x50 > > > [ 575.218075] [] nmi_handle+0x60/0x130 > > > [ 575.218086] [] ? poll_idle+0x3e/0x70 > > > [ 575.218096] [] do_nmi+0x140/0x470 > > > [ 575.218108] [] end_repeat_nmi+0x1a/0x1e > > > [ 575.218119] [] ? poll_idle+0x3e/0x70 > > > [ 575.218129] [] ? poll_idle+0x3e/0x70 > > > [ 575.218139] [] ? poll_idle+0x3e/0x70 > > > [ 575.218148] <> [] cpuidle_enter_state+0xf3/0x2f0 > > > [ 575.218164] [] cpuidle_enter+0x17/0x20 > > > [ 575.218175] [] call_cpuidle+0x2a/0x40 > > > [ 575.218185] [] cpu_startup_entry+0x273/0x330 > > > [ 575.218196] [] start_secondary+0x10e/0x130 > > > > > > However, not servicing all available IIR within the handler does hurt the > > > throughput of pathological nop execbuf by about 20%, with a similar effect > > > upon the dispatch latency of a series of execbuf. > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93467 > > > Testcase: igt/gem_exec_nop/basic # requires NMI watchdog > > > Signed-off-by: Chris Wilson > > > Cc: Ville Syrj�l� > > > Cc: Antti Koskip�� > > Cc: Tvrtko Ursulin > > > Cc: stable@vger.kernel.org > > > --- > > > drivers/gpu/drm/i915/i915_irq.c | 40 +++++++++++++++++++--------------------- > > > 1 file changed, 19 insertions(+), 21 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > > > index 53e5104964b3..8a3230427884 100644 > > > --- a/drivers/gpu/drm/i915/i915_irq.c > > > +++ b/drivers/gpu/drm/i915/i915_irq.c > > > @@ -1829,35 +1829,33 @@ static irqreturn_t cherryview_irq_handler(int irq, void *arg) > > > /* IRQs are synced during runtime_suspend, we don't require a wakeref */ > > > disable_rpm_wakeref_asserts(dev_priv); > > > > > > - for (;;) { > > > - master_ctl = I915_READ(GEN8_MASTER_IRQ) & ~GEN8_MASTER_IRQ_CONTROL; > > > - iir = I915_READ(VLV_IIR); > > > + master_ctl = I915_READ(GEN8_MASTER_IRQ) & ~GEN8_MASTER_IRQ_CONTROL; > > > + iir = I915_READ(VLV_IIR); > > > > > > - if (master_ctl == 0 && iir == 0) > > > - break; > > > + if (master_ctl == 0 && iir == 0) > > > + break; > > > > goto something? > > Sigh. The problem of rewriting the "obvious" patch against -nightly. I > just changed the for(;;) into do {} while(0) for testing. Perhaps I > should stick with that in case we need to flip flop agin. > > > Apart from that I have no objections if it doesn't cause problems > > with interrupts getting lost and whatnot. That was the original reason > > for it I think, but at least I myself never really looked into it. IIRC > > Rafael just told me they needed to do it to get the thing working, so > > I just put the patch in. And that was before I had even seen any silicon. > > My testing only looks at the GT side, and we do stress that pretty hard > because of execlists and have reasonable methods of detection if we stop > processing execbuf. I'm more worried about the display and pipe interrupts. IIRC GT was where the problem was originally. And just as a side note, I do have a branch somewhere that rewrites all the gmch irq handlers to not loop. Just never actually found the time to really run it on anything :) So I like moving towards that direction in any case. -- Ville Syrj�l� Intel OTC