From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Exit cherryview_irq_handler() after one pass Date: Thu, 10 Mar 2016 15:01:20 +0200 Message-ID: <20160310130120.GH10446@intel.com> References: <1457610268-25299-1-git-send-email-chris@chris-wilson.co.uk> <20160310120127.GD10446@intel.com> <20160310121046.GN1405@nuc-i3427.alporthouse.com> <20160310122439.GF10446@intel.com> <20160310124248.GQ1405@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160310124248.GQ1405@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , intel-gfx@lists.freedesktop.org, Antti =?iso-8859-1?Q?Koskip=E4=E4?= , Tvrtko Ursulin , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 10, 2016 at 12:42:48PM +0000, Chris Wilson wrote: > On Thu, Mar 10, 2016 at 02:24:39PM +0200, Ville Syrj=E4l=E4 wrote: > > On Thu, Mar 10, 2016 at 12:10:46PM +0000, Chris Wilson wrote: > > > My testing only looks at the GT side, and we do stress that prett= y hard > > > because of execlists and have reasonable methods of detection if = we stop > > > processing execbuf. I'm more worried about the display and pipe i= nterrupts. > >=20 > > IIRC GT was where the problem was originally. >=20 > Before execlists, the only source of GT interrupts would be > user-interrupts. There the problem is usually not so much that we mis= s > the GT interrupt, but that the seqno write is not completed by the ti= me > the interrupt is asserted. I hope that was the problem you saw. IIRC those guys already had execlists in use with their Android stuff. But we did have that whole snooping mess still unresolved at the time so who knows what was really going on. --=20 Ville Syrj=E4l=E4 Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:50343 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbcCJNBZ (ORCPT ); Thu, 10 Mar 2016 08:01:25 -0500 Date: Thu, 10 Mar 2016 15:01:20 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson , intel-gfx@lists.freedesktop.org, Antti =?iso-8859-1?Q?Koskip=E4=E4?= , Tvrtko Ursulin , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Exit cherryview_irq_handler() after one pass Message-ID: <20160310130120.GH10446@intel.com> References: <1457610268-25299-1-git-send-email-chris@chris-wilson.co.uk> <20160310120127.GD10446@intel.com> <20160310121046.GN1405@nuc-i3427.alporthouse.com> <20160310122439.GF10446@intel.com> <20160310124248.GQ1405@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160310124248.GQ1405@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Mar 10, 2016 at 12:42:48PM +0000, Chris Wilson wrote: > On Thu, Mar 10, 2016 at 02:24:39PM +0200, Ville Syrj�l� wrote: > > On Thu, Mar 10, 2016 at 12:10:46PM +0000, Chris Wilson wrote: > > > My testing only looks at the GT side, and we do stress that pretty hard > > > because of execlists and have reasonable methods of detection if we stop > > > processing execbuf. I'm more worried about the display and pipe interrupts. > > > > IIRC GT was where the problem was originally. > > Before execlists, the only source of GT interrupts would be > user-interrupts. There the problem is usually not so much that we miss > the GT interrupt, but that the seqno write is not completed by the time > the interrupt is asserted. I hope that was the problem you saw. IIRC those guys already had execlists in use with their Android stuff. But we did have that whole snooping mess still unresolved at the time so who knows what was really going on. -- Ville Syrj�l� Intel OTC