From: David Disseldorp <ddiss@suse.de>
To: Mike Christie <mchristi@redhat.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] ceph osd: add support for new op cmpext
Date: Thu, 10 Mar 2016 13:03:41 +0100 [thread overview]
Message-ID: <20160310130341.444c76af@g21.suse.de> (raw)
In-Reply-To: <1457591672-17430-3-git-send-email-mchristi@redhat.com>
Hi Mike,
On Thu, 10 Mar 2016 00:34:32 -0600, Mike Christie wrote:
> This adds support for a new op cmpext. The request will read
> extent.length bytes and compare them to extent.length bytes at
> extent.offset on disk. If there is a miscompare the osd will return
> -EILSEQ, and the mismatched buffer that was read.
>
> rbd will use this in a multi op request to implement the
> SCSI COMPARE_AND_WRITE request which is used by VMware for
> its atomic test and set request.
>
> v2:
> - Merge David's tracing fixes.
> - Instead of returning the mismatch offset and buffer on matching
> failure just return the buffer. The client can figure out the offset
> if it needs it.
What's your reason for dropping the mismatch offset? The osd has
to perform the comparison, so might as well do something with the
result, even if it's ignored by the client in some cases.
Cheers, David
next prev parent reply other threads:[~2016-03-10 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/2] ceph osd: initial VMware VAAI support>
2016-03-10 6:34 ` (unknown), Mike Christie
2016-03-10 6:34 ` [PATCH 1/2] ceph osd: add support for new op writesame Mike Christie
2016-03-10 12:03 ` David Disseldorp
2016-03-10 6:34 ` [PATCH 2/2] ceph osd: add support for new op cmpext Mike Christie
2016-03-10 12:03 ` David Disseldorp [this message]
2016-03-10 17:06 ` Mike Christie
2016-03-10 17:12 ` David Disseldorp
2016-03-10 6:36 ` [PATCH 0/2] ceph osd: initial VMware VAAI support Mike Christie
2016-03-10 12:04 ` David Disseldorp
2016-03-10 22:45 ` Josh Durgin
2016-03-11 4:46 ` Ric Wheeler
2016-03-11 10:03 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310130341.444c76af@g21.suse.de \
--to=ddiss@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.