From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v4 7/9] IB/core: generic RDMA READ/WRITE API Date: Thu, 10 Mar 2016 17:21:50 +0100 Message-ID: <20160310162150.GA9544@lst.de> References: <1457461000-24088-1-git-send-email-hch@lst.de> <1457461000-24088-8-git-send-email-hch@lst.de> <56DF44FC.8070103@sandisk.com> <20160309130723.GD31210@lst.de> <20160309155457.GA1898@lst.de> <56E071B6.8060809@sandisk.com> <20160310075722.GA551@lst.de> <56E1931C.1040206@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56E1931C.1040206-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Christoph Hellwig , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org Hi Bart, I see the use case for enabling MRs for debugging, but I still don't think the ULP is the right place. I also don't see where you cna do this currently: for srpt, the only driver converted in this series there is no support for registrations at all currently, and with the the series you can force it to register with a one line code change in rdma_rw_use_mr. For iSERt, which I plan to convert for 4.7 (and which has some WIP code in git) MR support exists, but is only enabled if the device supports the vendor specific signature handover extension (aka if running on mlx5 hardware). With the future conversion you'll still have a simply compile time switch to always enabled it, and I'd be fine with adding a module parameter to force it as well. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html