All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeeja KP <jeeja.kp@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, vinod.koul@intel.com, alsa-devel@alsa-project.org,
	liam.r.girdwood@intel.com, patches.audio@intel.com
Subject: Re: [alsa-devel] [RFD] Add hw_params support for hostless stream BE DAIs
Date: Fri, 11 Mar 2016 02:27:03 +0530	[thread overview]
Message-ID: <20160310205703.GA26632@jeeja.kp@intel.com> (raw)
In-Reply-To: <20160302020215.GN18327@sirena.org.uk>

On Wed, Mar 02, 2016 at 11:02:15AM +0900, Mark Brown wrote:
> On Tue, Feb 16, 2016 at 09:47:47PM +0530, Jeeja KP wrote:
> > We have no mechanism to configure hw_params for DAIs which are hostless.
> > Like a loop or DAIs connected to internal sinks/sources.
> 
> Please propose patches, don't send enormous design documents.  They're
> big, take a long time to read and don't really get us anywhere unless
> they're extremely clear.

Ok. I have the patches ready, will post it.

> 
> > Approach:
> > 	1. Allow params to be defined for other BE dai link also. this
> > 	currently applicable only for codec_codec link.
> 
> Like I keep saying if you're thinking about this in terms of DPCM you're
> solving the wrong problem - we already support supplying parameters for
> device<->device links, we already have systems that need to configure
> things for device<->device links so we can already see that if we're
> doing something that only works for things that are on SoC and can use
> DPCM then we're not solving the problem.

No this is not exactly about DPCM. It is about the device<->device links that
assume you can have only codecs as hostless and thus change the direction
for the link. Since we are rendering from SoC we don't need direction change.

> 
> DPCM works pretty well for small, simple DSPs that are mostly in line
> in the middle of a standard DAI but it does have limitations which
> you're now running into.  Your systems don't fit well with what DPCM
> supports naturally.
> 
> > struct snd_soc_dai_link {
> >         const struct snd_soc_pcm_stream *params;
> >         unsigned int num_params;
> > 
> > +       /* flag to create codec codec based on the flag*/
> > +       unsigned int codec_link:1;
> > +
> 
> This is clearly confused, if we can't figure out what the two devices we
> are connecting are based on just looking at the devices then that's
> really not a good sign that our interfaces are sensible and easy to work
> with.

Right now dai_link assumes device<->device links based on params so we
cannot specify params for anything where we dont want direction change and would
like to treat as normal direction dai_link. So we propose this to move to
codec_link flag and use params only for creating controls based on params
provided.


-- 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2016-03-10 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160216161747.GA18103@jeeja.kp@intel.com>
2016-02-23 10:51 ` [RFD] Add hw_params support for hostless stream BE DAIs Liam Girdwood
2016-02-26  6:47   ` Vinod Koul
2016-03-02  2:04   ` Mark Brown
2016-03-02  2:02 ` Mark Brown
2016-03-10 20:57   ` Jeeja KP [this message]
2016-03-11  3:59     ` Mark Brown
2016-03-14 17:57       ` [alsa-devel] " Jeeja KP
2016-03-14 11:12         ` Mark Brown
2016-03-14 17:57       ` Jeeja KP
2016-03-10 20:57   ` Jeeja KP

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160310205703.GA26632@jeeja.kp@intel.com \
    --to=jeeja.kp@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.