From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933370AbcCKBlc (ORCPT ); Thu, 10 Mar 2016 20:41:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39634 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933020AbcCKBl2 (ORCPT ); Thu, 10 Mar 2016 20:41:28 -0500 Date: Thu, 10 Mar 2016 17:41:22 -0800 From: Greg Kroah-Hartman To: Lu Baolu Cc: Felipe Balbi , Mathias Nyman , Lee Jones , Heikki Krogerus , MyungJoo Ham , Chanwoo Choi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/7] usb: add support for Intel dual role port mux Message-ID: <20160311014122.GA4131@kroah.com> References: <1457423628-3183-1-git-send-email-baolu.lu@linux.intel.com> <20160311000328.GC2586@kroah.com> <56E20F5B.3050204@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E20F5B.3050204@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2016 at 08:20:43AM +0800, Lu Baolu wrote: > > > On 03/11/2016 08:03 AM, Greg Kroah-Hartman wrote: > > On Tue, Mar 08, 2016 at 03:53:41PM +0800, Lu Baolu wrote: > >> Intel SOC chips are featured with USB dual role. The host role is > >> provided by Intel xHCI IP, and the gadget role is provided by IP > >> from designware. Tablet platform designs always share a single > >> port for both host and gadget controllers. There is a mux to > >> switch the port to the right controller according to the cable > >> type. OS needs to provide the callback to control the mux when > >> a plug-in event raises. The method to control the mux is platform > >> dependent. At least three types of implementation can be found > >> across current devices. 1) GPIO pins; 2) a unit which can be > >> controlled by memory mapped registers; 3) ACPI ASL code. > >> > >> This patch series adds supports for Intel dual role port mux. > >> It includes: > >> (1) A helper layer on top of extcon for individual mux driver. > >> It listens to the USB-HOST extcon cable and call the switch > >> call-back when the cable state changes. > >> (2) Drivers for GPIO controlled port mux which could be found on > >> Baytrail devices. A mfd driver is used to split the GPIOs into > >> USB gpio extcon device and a USB mux device. Driver for USB > >> gpio extcon device is already in upstream Linux. This patch > >> series includes a driver for GPIO USB mux. > >> (3) Drivers for USB port mux controlled through memory mapped > >> registers and the logic to create the mux device. This type > >> of dual role port mux could be found in Cherry Trail and > >> Broxton devices. > >> > >> Lu Baolu (7): > >> extcon: usb-gpio: add device binding for platform device > >> extcon: usb-gpio: add support for ACPI gpio interface > >> usb: mux: add common code for Intel dual role port mux > >> usb: mux: add driver for Intel gpio controlled port mux > >> usb: mux: add driver for Intel drcfg controlled port mux > >> usb: pci-quirks: add Intel USB drcfg mux device > >> mfd: intel_vuport: Add Intel virtual USB port MFD Driver > > You don't describe here what you changed from v2, or even from v1. > > Please always be specific, we don't remember what your last submissions > > looked like at all... > > I am sorry. I put the change log after file change summary. > I will move it up here next time. Ah, totally missed it, sorry about that am not expecting that below a diffstat. greg k-h