All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Otubo <eduardo.otubo@profitbricks.com>
To: mrezanin@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Whitelist sysinfo call
Date: Fri, 11 Mar 2016 09:51:50 +0100	[thread overview]
Message-ID: <20160311085150.GA24308@vader> (raw)
In-Reply-To: <1457343286-16019-1-git-send-email-mrezanin@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Mon, Mar 07, 2016 at 10=34=46AM +0100, mrezanin@redhat.com wrote:
> From: Miroslav Rezanina <mrezanin@redhat.com>
> 
> Newer version of nss-softokn libraries (> 3.16.2.3) use sysinfo call
> so qemu using rbd image hang after start when run in sandbox mode.
> 
> To allow using rbd images in sandbox mode we have to whitelist it.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
>  qemu-seccomp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 2866e3c..e29fca1 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -250,6 +250,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
>  #ifdef HAVE_CACHEFLUSH
>      { SCMP_SYS(cacheflush), 240 },
>  #endif
> +    { SCMP_SYS(sysinfo), 240 },

Are you sure you want to add this syscall to the bottom of the list? Did
you estimate the frequency it is called by running strace?

Thanks for the patch.

-- 
Eduardo Otubo
ProfitBricks GmbH

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-03-11  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07  9:34 [Qemu-devel] [PATCH] Whitelist sysinfo call mrezanin
2016-03-11  8:51 ` Eduardo Otubo [this message]
2016-03-21 12:17   ` Miroslav Rezanina
2016-04-01  8:47     ` Eduardo Otubo
2016-04-11 20:19 ` Serge Hallyn
2016-04-12 11:53   ` Eduardo Otubo
2016-04-12 12:03     ` Miroslav Rezanina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311085150.GA24308@vader \
    --to=eduardo.otubo@profitbricks.com \
    --cc=armbru@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.