From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id C6202E008EE; Fri, 11 Mar 2016 05:02:46 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.24 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 98E5AE00833 for ; Fri, 11 Mar 2016 05:02:43 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 11 Mar 2016 05:02:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,320,1455004800"; d="scan'208";a="667674198" Received: from linux.intel.com ([10.23.219.25]) by FMSMGA003.fm.intel.com with ESMTP; 11 Mar 2016 05:02:28 -0800 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id 92AFF2C8001; Fri, 11 Mar 2016 05:50:12 -0800 (PST) Date: Fri, 11 Mar 2016 12:42:35 +0200 From: Ed Bartosh To: "Barros Pena, Belen" Message-ID: <20160311104235.GA6148@linux.intel.com> References: MIME-Version: 1.0 In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "toaster@yoctoproject.org" Subject: Re: [PATCH v2 00/15] per project build directory X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 13:02:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Belen, Thank you for the review. My comments are below. On Wed, Mar 09, 2016 at 11:40:04AM +0000, Barros Pena, Belen wrote: > >This is how to test this: > > - run toaster > > - run command line build: build zlib > > This shows a warning about build history not being enabled. I know you > already know about this, but just for completeness ;) > Should be fixed in v3. > > - check if it's shown in Toaster UI > > Builds started from CLI do show in the web UI, but once they complete they > are missing layer and package information. I guess that's connected with > the build history issue above > Most probably it is. > > - create project for Yocto master > > - trigger project build from UI > > The build I triggered from the Toaster web UI from a Yocto master project > (core-image-minimal) failed with this traceback: > > /bin/sh: 1: source: not found > > Traceback (most recent call last): > File > "/home/yocto/master/bitbake/lib/toaster/bldcontrol/management/commands/runb > uilds.py", line 58, in schedule > br.brtarget_set.all(), "%d:%d" % (br.pk, bec.be.pk)) > File > "/home/yocto/master/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > ", line 261, in triggerBuild > self._shellcmd('source %s %s' % (oe_init, builddir), self.be.sourcedir) > File > "/home/yocto/master/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > ", line 70, in _shellcmd > raise ShellCmdException(err) > ShellCmdException: command: source > /home/yocto/master/_toaster_clones/_git___git.yoctoproject.org_poky_master/ > oe-init-build-env /home/yocto/master/build-toaster-master project > /bin/sh: 1: source: not found > This is related to your shell (dash on Ubuntu I guess). Should be fixed in v3. > After all the above there is only one build directory created, the one > that was generated when running the build from CLI. Also: > > * I can no longer find the toaster_ui.log file It will be in build directory. You didn't see it as toaster crashed and didn't create build directory. > * It looks like the builds are still using build/sstate-cache and > build/downloads as SSTATE_DIR and DL_DIR, but I think we agreed that > projects by default would share those 2 directories, which I guess means > they have to move outside the build directory, although I could be mistaken > This functionality is implemented in another patchset I think. I'm going to make it working on top of my changes after I'm done with my patchset. The same with build cancelation patchset - I'll make it working after this one is accepted. > * _toaster_clones is still being created in the root checkout directory, > which I guess makes sense > > * A pending question is where the toaster-custom-images layer we generate > when building custom images should be. I had a brief chat with Michael > about this, and I think we concluded the layer should not be shared across > projects, which means we should create one per project and they should be > inside the project build dir. Right now the _meta-toaster-custom directory > is also in the root checkout directory It makes sense to me. However, I'd rather not do it until this patchset is tested and accepted. Otherwise amount of patches and new functionality in this patchset will grow and it will be harder to maintain it. Thank you! Ed