All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: lustre: obdclass: Use list_first_entry_or_null
Date: Fri, 11 Mar 2016 09:08:08 -0800	[thread overview]
Message-ID: <20160311170808.GA11560@kroah.com> (raw)
In-Reply-To: <1457275178-9647-1-git-send-email-bhumirks@gmail.com>

On Sun, Mar 06, 2016 at 08:09:38PM +0530, Bhumika Goyal wrote:
> This patch replaces list_empty and list_entry with
> list_first_entry_or_null as it makes the code cleare to read. Also removed the 
> {} around if-statement.
> Done using coccinelle:
> 
> @@
> expression e1,e2;
> statement S;
> @@
> - if(!list_empty(...)){
>   e2=
> - list_entry(e1.next,
> + list_first_entry_or_null(&e1,
>   ...);
> + if(e2){
> ...
> }
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/genops.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Does not apply to my tree :(



      reply	other threads:[~2016-03-11 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 14:39 [PATCH] Staging: lustre: obdclass: Use list_first_entry_or_null Bhumika Goyal
2016-03-11 17:08 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311170808.GA11560@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhumirks@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.