Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: Clean up tests on the results of functions that return NULL on failure.

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 06, 2016 at 02:48:58PM +0530, G Pooja Shamili wrote:
> Functions returning NULL as a return value on failure can be tested for
> as !x, NULL == x or x == NULL. As !x is commonly used, all the tests
> need to be modified to use !x for a consistent coding style. In this
> patch, the function kzalloc is considered.
> 
> Coccinelle is used to achieve this, the semantic patch being:
> 
> @@
> expression E;
> statement S;
> @@
> 
> E = kzalloc(...);
> 
> if (
> (
> +	!
> 	E
> -	== NULL
> |
> +	!
> -	NULL ==
> 	E
> )
>  ) S
> 
> Signed-off-by: G Pooja Shamili <poojashamili@gmail.com>
> ---
> Changes from Version 1:
> 	    * Changed the name in the From: and Signed-off-by: to full
> name.	    

You sent me 2 patches with pretty much the identical subject line, yet
they all did 3 different things.  Please fix up and resend as a patch
series.

thanks,

greg k-h