Re: [Outreachy kernel] [PATCH 08/10] staging: octeon: Use type s32 instead of int32_t

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Feb 28, 2016 at 12:45:53AM +0100, Laura Garcia Liebana wrote:
> Prefer the use of type s32 instead of int32_t. Checkpatch detected these
> issues.
> 
> Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
> ---
>  drivers/staging/octeon/ethernet-tx.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index 024263d4..db04388 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -58,9 +58,9 @@ static DECLARE_TASKLET(cvm_oct_tx_cleanup_tasklet, cvm_oct_tx_do_cleanup, 0);
>  /* Maximum number of SKBs to try to free per xmit packet. */
>  #define MAX_SKB_TO_FREE (MAX_OUT_QUEUE_DEPTH * 2)
>  
> -static inline int32_t cvm_oct_adjust_skb_to_free(int32_t skb_to_free, int fau)
> +static inline s32 cvm_oct_adjust_skb_to_free(s32 skb_to_free, int fau)

These really can all be switched to 'int', right?

thanks,

greg k-h