From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events
Date: Fri, 11 Mar 2016 19:14:58 +0100 [thread overview]
Message-ID: <20160311181458.GA1060@krava.redhat.com> (raw)
In-Reply-To: <20160311134814.GA25533@danjae.kornet>
On Fri, Mar 11, 2016 at 10:48:14PM +0900, Namhyung Kim wrote:
SNIP
> > > > What about checking is_sampling_event() first and goto the last
> > > > paranoid_tracepoint_raw check instead? This way we can remove the
> > > > same check in the function trace case.
> > >
> > > right, will check
> >
> > hum, did you mean something like this?
> >
> > I'd rather keep it the original way.. seems more straight
>
> Hmm.. I think I was wrong. But it seems we can simply return 0 for
> non sampling case. How about this?
yep, that seems better.. will post v2
thanks,
jirka
next prev parent reply other threads:[~2016-03-11 18:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 20:46 [RFC 0/5] ftrace perf: Fixes and speedup Jiri Olsa
2016-03-09 20:46 ` [PATCH 1/5] ftrace perf: Check sample types only for sampling events Jiri Olsa
2016-03-10 0:36 ` Namhyung Kim
2016-03-10 7:25 ` Jiri Olsa
2016-03-11 8:36 ` Jiri Olsa
2016-03-11 13:48 ` Namhyung Kim
2016-03-11 18:14 ` Jiri Olsa [this message]
2016-03-15 20:06 ` Steven Rostedt
2016-03-15 21:51 ` Jiri Olsa
2016-03-09 20:46 ` [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event Jiri Olsa
2016-03-10 0:39 ` Namhyung Kim
2016-03-11 8:39 ` Jiri Olsa
2016-03-09 20:46 ` [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Jiri Olsa
2016-03-10 1:29 ` Namhyung Kim
2016-03-09 20:46 ` [PATCH 4/5] ftrace: Make ftrace_hash_rec_enable return update bool Jiri Olsa
2016-03-11 14:28 ` Namhyung Kim
2016-03-11 18:15 ` Jiri Olsa
2016-03-12 8:35 ` Namhyung Kim
2016-03-15 19:43 ` Steven Rostedt
2016-03-09 20:46 ` [PATCH 5/5] ftrace: Update dynamic ftrace calls only if necessary Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2016-03-16 14:34 [PATCHv2 0/5] ftrace perf: Fixes and speedup Jiri Olsa
2016-03-16 14:34 ` [PATCH 1/5] ftrace perf: Check sample types only for sampling events Jiri Olsa
2016-03-18 14:27 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311181458.GA1060@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.