From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6260469597645832192 X-Received: by 10.140.102.163 with SMTP id w32mr8300890qge.10.1457721180107; Fri, 11 Mar 2016 10:33:00 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.82.42 with SMTP id g39ls2750275qgd.50.gmail; Fri, 11 Mar 2016 10:32:59 -0800 (PST) X-Received: by 10.140.99.106 with SMTP id p97mr8296777qge.13.1457721179562; Fri, 11 Mar 2016 10:32:59 -0800 (PST) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id ui7si1549352pab.0.2016.03.11.10.32.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Mar 2016 10:32:59 -0800 (PST) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (c-50-170-35-168.hsd1.wa.comcast.net [50.170.35.168]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3DA3DA04; Fri, 11 Mar 2016 18:32:59 +0000 (UTC) Date: Fri, 11 Mar 2016 10:32:57 -0800 From: Greg KH To: Bhaktipriya Shridhar Cc: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: xmit_linux: Remove unnecessary else after return Message-ID: <20160311183257.GA26639@kroah.com> References: <20160310164711.GA18407@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160310164711.GA18407@Karyakshetra> User-Agent: Mutt/1.5.24 (2015-08-30) On Thu, Mar 10, 2016 at 10:17:12PM +0530, Bhaktipriya Shridhar wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/staging/rtl8712/xmit_linux.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Did not apply to my tree :(