All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg Kroah-Hartman)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging: dgnc: Remove useless and deadly judgment
Date: Fri, 11 Mar 2016 13:29:32 -0800	[thread overview]
Message-ID: <20160311212932.GA19787@kroah.com> (raw)
In-Reply-To: <20160229064133.GA14862@debian>

On Mon, Feb 29, 2016 at 02:41:34PM +0800, Navy Cheng wrote:
> pci_unregister_driver() should be used once dgnc module exit. It has
> nothing to do with dgnc_NumBoards. Remove the judgment of dgnc_NumBoards to
> avoid pci_unregister_driver() is not used when dgnc_NumBoards is 0.
> 
> Signed-off-by: Navy Cheng <navych@126.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index fc6d298..20b0c3b 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -156,8 +156,7 @@ static void dgnc_cleanup_module(void)
>  
>  	dgnc_tty_post_uninit();
>  
> -	if (dgnc_NumBoards)
> -		pci_unregister_driver(&dgnc_driver);
> +	pci_unregister_driver(&dgnc_driver);
>  }
>  
>  /*

Someone else sent a patch that did much this same thing 2 days before
you did.

Also please use the get_maintainers.pl file to determine the correct
mailing list to send patches like this to (hint, it's not
kernelnewbies...)

thanks,

greg k-h

      parent reply	other threads:[~2016-03-11 21:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  6:41 [PATCH] staging: dgnc: Remove useless and deadly judgment Navy Cheng
2016-02-29  7:58 ` Valdis.Kletnieks at vt.edu
2016-02-29 12:27   ` Navy Cheng
2016-03-11 21:29 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311212932.GA19787@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.