From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change Date: Fri, 11 Mar 2016 14:00:09 -0800 Message-ID: <20160311220009.GC11274@kroah.com> References: <1457034046-27678-5-git-send-email-gustavo@padovan.org> <1457044963-5785-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 435066EB63 for ; Fri, 11 Mar 2016 22:00:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMDMsIDIwMTYgYXQgMDc6NDI6NDNQTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9y YS5jby51az4KPiAKPiBCdXJuIHRoZSBvbGQgb3Bjb2RlIHRvIGF2b2lkIGFueSBwb3RlbnRpYWwg b2xkIHVzZXJzcGFjZSBydW5uaW5nIHRoZSBvbGQKPiBBUEkgdG8gZ2V0IHdlaXJkIGVycm9ycy4g Q2hhbmdpbmcgdGhlIG9wY29kZXMgd2lsbCBtYWtlIHRoZW0gZmFpbCByaWdodAo+IGF3YXkuCj4g Cj4gVGhpcyBpcyBqdXN0IGEgcHJlY2F1dGlvbiwgdGhlcmUgbm8gdXBzdHJlYW0gdXNlcnMgb2Yg dGhlc2UgaW50ZXJmYWNlcwo+IHlldCBhbmQgdGhlIG9ubHkgdXNlciBpcyBBbmRyb2lkLCBidXQg d2UgZG9uJ3QgZXhwZWN0IGFueW9uZSB0cnlpbmcgdG8KPiBydW4gYW5kcm9pZCB1c2Vyc3BhY2Ug YW5kIGFsbCBpdCBkZXBlbmRlbmNpZXMgb24gdG9wIG9mIHVwc3RyZWFtIGtlcm5lbHMuCj4gCj4g TW9yZW92ZXIgQW5kcm9pZCBzaG91bGQgYmUgY29udmVydGVkIHRvIHVzZSB1cHN0cmVhbSBzeW5j X2ZpbGVzLgo+IAo+IFN1Z2dlc3RlZC1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxh Ym9yYS5jby51az4KPiAtLS0KPiAgZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvdWFwaS9zeW5jLmgg fCAxMSArKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQoKV2hlcmUgZG9lcyB0aGlzIGJlbG9uZyBpbiB0aGlzIHBhdGNoIHNlcmllcz8g IEJlZm9yZSBpdD8gIEFmdGVyIGl0PyAgSW4KdGhlIG1pZGRsZT8KClBsZWFzZSByZXNlbmQgdGhl IHdob2xlIHNlcmllcywgZ2F0aGVyIHVwIGFsbCBvZiB0aGUgcmV2aWV3ZWQgYW5kCnNpZ25lZC1v ZmYtYnkgbWFya2luZ3MgZnJvbSBldmVyeW9uZSBpbnZvbHZlZCwgYW5kIEknbGwgYmUgZ2xhZCB0 byBhcHBseQp0aGVtLgoKdGhhbmtzLAoKZ3JlZyBrLWgKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932710AbcCKWAN (ORCPT ); Fri, 11 Mar 2016 17:00:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58464 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbcCKWAK (ORCPT ); Fri, 11 Mar 2016 17:00:10 -0500 Date: Fri, 11 Mar 2016 14:00:09 -0800 From: Greg Kroah-Hartman To: Gustavo Padovan Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change Message-ID: <20160311220009.GC11274@kroah.com> References: <1457034046-27678-5-git-send-email-gustavo@padovan.org> <1457044963-5785-1-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 07:42:43PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Burn the old opcode to avoid any potential old userspace running the old > API to get weird errors. Changing the opcodes will make them fail right > away. > > This is just a precaution, there no upstream users of these interfaces > yet and the only user is Android, but we don't expect anyone trying to > run android userspace and all it dependencies on top of upstream kernels. > > Moreover Android should be converted to use upstream sync_files. > > Suggested-by: Rob Clark > Signed-off-by: Gustavo Padovan > --- > drivers/staging/android/uapi/sync.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) Where does this belong in this patch series? Before it? After it? In the middle? Please resend the whole series, gather up all of the reviewed and signed-off-by markings from everyone involved, and I'll be glad to apply them. thanks, greg k-h