From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jim Fehlig <jfehlig@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Bruce Rogers <brogers@suse.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [RFC] tools: don't use qemu default config
Date: Fri, 11 Mar 2016 17:28:29 -0500 [thread overview]
Message-ID: <20160311222829.GD23682@char.us.oracle.com> (raw)
In-Reply-To: <56E341DE.4070604@suse.com>
On Fri, Mar 11, 2016 at 03:08:30PM -0700, Jim Fehlig wrote:
> I recently changed SUSE's Xen package to use the distro qemu instead of building
> qemu-xen. This got some other eyes looking at Xen's use of qemu and it was
> noticed that libxl and xen-qemu-dom0-disk-backend.service do not include
> '-no-user-config' when invoking qemu. The latter also does not include
> '-nodefaults'. Commit 6ef823fd added '-nodefaults' to the qemu args created by
> libxl, but missed adding it to the qemu args in xen-qemu-dom0-disk-backend.service.
>
> I _think_ adding '-nodefaults' to the qemu args in the service file is
> non-controversial. What do folks think of also adding '-no-user-config'? It
> seems the global config in /etc/qemu/qemu.conf would end up being more
> problematic than helpful for Xen.
Is there a description (or URL) of what one can jam in there?
>
> As a side note, the libvirt qemu driver includes '-no-user-config -nodefaults'
> in all its qemu invocations to avoid configuration which it doesn't control.
>
> WRT qemu args, another suggestion was to explicitly specify 'accel=xen' in the
> machine arg. Together, these changes would e.g. result in the service file qemu
> args changing slightly to
>
> -machine xenpv,accel=xen -xen-domid 0 -xen-attach -name dom0 \
> -daemonize -no-user-config -nodefaults -display none \
> -pidfile /var/run/xen/qemu-dom0.pid
>
> If folks agree with these changes, I'll be happy to provide a patches for libxl
> and the systemd service file. Thanks for your comments.
>
> Regards,
> Jim
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-11 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 22:08 [RFC] tools: don't use qemu default config Jim Fehlig
2016-03-11 22:28 ` Konrad Rzeszutek Wilk [this message]
2016-03-14 19:56 ` Jim Fehlig
2016-03-12 14:34 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311222829.GD23682@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=brogers@suse.com \
--cc=jfehlig@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.