From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6258950529072758784 X-Received: by 10.129.155.147 with SMTP id s141mr9333898ywg.5.1457735386029; Fri, 11 Mar 2016 14:29:46 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.50.142.1 with SMTP id rs1ls277342igb.7.canary; Fri, 11 Mar 2016 14:29:45 -0800 (PST) X-Received: by 10.98.12.66 with SMTP id u63mr6103758pfi.12.1457735385697; Fri, 11 Mar 2016 14:29:45 -0800 (PST) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id 12si1616588pfb.1.2016.03.11.14.29.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Mar 2016 14:29:45 -0800 (PST) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (c-50-170-35-168.hsd1.wa.comcast.net [50.170.35.168]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 6318CC2B; Fri, 11 Mar 2016 22:29:45 +0000 (UTC) Date: Fri, 11 Mar 2016 14:29:45 -0800 From: Greg KH To: G Pooja Shamili Cc: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2] staging: mt29f_spinand: Replacing pr_err with dev_err after the call to devm_kzalloc Message-ID: <20160311222945.GA26433@kroah.com> References: <20160306144436.GA6623@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160306144436.GA6623@localhost> User-Agent: Mutt/1.5.24 (2015-08-30) On Sun, Mar 06, 2016 at 08:14:36PM +0530, G Pooja Shamili wrote: > The function devm_kzalloc has a first argument of type struct device *. > This is the type of argument required by printing functions such as > dev_info, dev_err, etc. Thus, functions like pr_info should not normally > be used after a call to devm_kzalloc. Thus, all pr_info occurances are > replaced with dev_info function calls. Your subject says "_err", not "_info" :(