All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Renaud Cerrato <r.cerrato@til-technologies.fr>
Subject: [rtc-linux] Re: [PATCH 1/3] rtc: pcf2127: conver to use regmap
Date: Sat, 12 Mar 2016 16:43:56 +0100	[thread overview]
Message-ID: <20160312154356.GA2693@piout.net> (raw)
In-Reply-To: <CAC5umyiwEWMdjPs6iZCUT0cn6W=RrGHMjHL-gR74KcT=C+ECgA@mail.gmail.com>

On 13/03/2016 at 00:39:34 +0900, Akinobu Mita wrote :
> The reason is regmap_i2c_read() doesn't work for this device because the
> STOP condition is required between set register address and read register
> data.  (Fig 45. Bus protocol, reading from registers in PCF2127.pdf)
> 
> I'll update this patch by adding that comment.

That would be great. You also have a small typo in the subject line.
Apart from that, I'm ready to take the patches.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

      reply	other threads:[~2016-03-12 15:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 16:22 [rtc-linux] [PATCH 1/3] rtc: pcf2127: conver to use regmap Akinobu Mita
2016-03-11 16:22 ` [rtc-linux] [PATCH 2/3] rtc: pcf2127: add support for spi interface Akinobu Mita
2016-03-11 16:22 ` [rtc-linux] [PATCH 3/3] rtc: pcf2127: add pcf2129 device id Akinobu Mita
2016-03-11 18:11 ` [rtc-linux] Re: [PATCH 1/3] rtc: pcf2127: conver to use regmap Alexandre Belloni
2016-03-12 15:39   ` Akinobu Mita
2016-03-12 15:43     ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160312154356.GA2693@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=akinobu.mita@gmail.com \
    --cc=r.cerrato@til-technologies.fr \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.