All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Hurley <peter@hurleysoftware.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrey Vagin <avagin@virtuozzo.com>,
	Konstantin Khorenko <khorenko@virtuozzo.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Pavel Emelianov <xemul@virtuozzo.com>
Subject: Re: [RFC] tty: n_tty -- Add new TIOCPEEKRAW ioctl to peek unread data
Date: Sun, 13 Mar 2016 13:35:23 +0300	[thread overview]
Message-ID: <20160313103523.GP1989@uranus.lan> (raw)
In-Reply-To: <56E53D96.3010107@suse.cz>

On Sun, Mar 13, 2016 at 11:14:46AM +0100, Jiri Slaby wrote:
> On 03/12/2016, 03:18 PM, Cyrill Gorcunov wrote:
> > --- linux-ml.git.orig/include/uapi/asm-generic/ioctls.h
> > +++ linux-ml.git/include/uapi/asm-generic/ioctls.h
> > @@ -77,6 +77,7 @@
> >  #define TIOCGPKT	_IOR('T', 0x38, int) /* Get packet mode state */
> >  #define TIOCGPTLCK	_IOR('T', 0x39, int) /* Get Pty lock state */
> >  #define TIOCGEXCL	_IOR('T', 0x40, int) /* Get exclusive mode state */
> > +#define TIOCPEEKRAW	_IOR('T', 0x41, void *)
> 
> Hi, this is not 32/64bit compatible and would need a compat ioctl number
> and a wrapper. Since it is char *, could you make it just 'char'?

Hi Jiri, sure, thanks! Lets wait for more feedback, maybe there some
other more elegant solution possible, which I failed to invent.

	Cyrill

  reply	other threads:[~2016-03-13 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12 14:18 [RFC] tty: n_tty -- Add new TIOCPEEKRAW ioctl to peek unread data Cyrill Gorcunov
2016-03-13 10:14 ` Jiri Slaby
2016-03-13 10:35   ` Cyrill Gorcunov [this message]
2016-03-16  9:48     ` [PATCH v2] " Cyrill Gorcunov
2016-03-17  4:05 ` [RFC] " Peter Hurley
2016-03-17  7:32   ` Cyrill Gorcunov
2016-03-22 11:00     ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160313103523.GP1989@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=avagin@virtuozzo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=khorenko@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=vdavydov@virtuozzo.com \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.