From: Andrew Lunn <andrew@lunn.ch>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org, Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: Handle parent interfaces in a different netns
Date: Sun, 13 Mar 2016 16:38:08 +0100 [thread overview]
Message-ID: <20160313153808.GC9674@lunn.ch> (raw)
In-Reply-To: <42883547.GmOm9E46Iz@sven-edge>
> > + const struct net *dev1_parent_net = net1;
> > + const struct net *dev2_parent_net = net2;
> > +
> > + if (dev1->rtnl_link_ops && dev1->rtnl_link_ops->get_link_net)
> > + dev1_parent_net = dev1->rtnl_link_ops->get_link_net(dev1);
> > + if (dev2->rtnl_link_ops && dev2->rtnl_link_ops->get_link_net)
> > + dev2_parent_net = dev2->rtnl_link_ops->get_link_net(dev2);
> [...]
> > + struct net *parent_net = net;
> [...]
> > + if (net_dev->rtnl_link_ops && net_dev->rtnl_link_ops->get_link_net)
> > + parent_net = net_dev->rtnl_link_ops->get_link_net(net_dev);
> > +
>
> My proposal is there to move this in an extra function [1] so adding compat
> code is easier [2].
Hi Sven
Do you want to squash your compact changes in and add your own
Signed-off-by?
Andrew
next prev parent reply other threads:[~2016-03-13 15:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 21:19 [B.A.T.M.A.N.] [PATCHv2 0/4] batman-adv: Add network name space support Andrew Lunn
2016-03-01 21:19 ` [B.A.T.M.A.N.] [PATCHv2 1/4] batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves Andrew Lunn
2016-03-13 9:29 ` Sven Eckelmann
2016-03-13 15:24 ` Andrew Lunn
2016-04-21 10:48 ` Marek Lindner
2016-03-01 21:19 ` [B.A.T.M.A.N.] [PATCHv2 2/4] batman-adv: Create batman soft interfaces within correct netns Andrew Lunn
2016-03-13 10:48 ` Sven Eckelmann
2016-03-13 15:35 ` Andrew Lunn
2016-03-01 21:19 ` [B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-03-04 12:35 ` Sven Eckelmann
2016-03-07 14:31 ` Andrew Lunn
2016-03-07 14:45 ` Sven Eckelmann
2016-03-11 23:37 ` Sven Eckelmann
2016-03-12 4:42 ` Antonio Quartulli
2016-03-12 7:34 ` Sven Eckelmann
2016-03-12 7:40 ` Sven Eckelmann
2016-03-07 4:21 ` Linus Lüssing
2016-03-07 13:47 ` Andrew Lunn
2016-03-13 11:02 ` Sven Eckelmann
2016-03-13 15:38 ` Andrew Lunn [this message]
2016-03-13 15:59 ` Sven Eckelmann
2016-03-01 21:19 ` [B.A.T.M.A.N.] [PATCHv2 4/4] batman-adv: debugfs: Add netns support Andrew Lunn
2016-03-07 14:21 ` Matthias Schiffer
2016-03-13 9:12 ` Sven Eckelmann
2016-03-13 15:42 ` Andrew Lunn
2016-04-18 14:41 ` Simon Wunderlich
2016-04-20 2:36 ` Andrew Lunn
2016-04-20 3:23 ` Antonio Quartulli
2016-04-20 7:02 ` Sven Eckelmann
2016-03-14 10:41 ` Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313153808.GC9674@lunn.ch \
--to=andrew@lunn.ch \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.