From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent Date: Sun, 13 Mar 2016 16:51:31 +0100 Message-ID: <20160313155131.GE9674@lunn.ch> References: <1457737300-23660-1-git-send-email-andrew@lunn.ch> <1457737300-23660-2-git-send-email-andrew@lunn.ch> <87io0qua3u.fsf@ketchup.mtl.sfl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev , Florian Fainelli To: Vivien Didelot Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:55723 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbcCMPvg (ORCPT ); Sun, 13 Mar 2016 11:51:36 -0400 Content-Disposition: inline In-Reply-To: <87io0qua3u.fsf@ketchup.mtl.sfl> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Mar 13, 2016 at 03:10:13AM -0400, Vivien Didelot wrote: > Andrew Lunn writes: > > > All the drivers support multiple chips, but mv88e6123_61_65 is the > > only one that reflects this in its naming. Change it to be consistent > > with the other drivers. > > > > Signed-off-by: Andrew Lunn > > Reviewed-by: Vivien Didelot > > When mv88e6xxx will become a driver by its own supporting different > devices, it'll be good to rename it to a reference driver as well, say > mv88e6352. In device tree land, the convention is to use the lowest version number supported. So it will probably be called mv88e6085.c. > > > diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c > > new file mode 100644 > > index 000000000000..69a6f79dcb10 > > --- /dev/null > > +++ b/drivers/net/dsa/mv88e6123.c > > @@ -0,0 +1,124 @@ > > Note that to avoid the big diff above, you can use the -M option of > git-format-patch to detect file renames. Yes, i always forget that. I wounder why it is not turned on by default? Maybe older versions of patch do not understand it? Andrew