All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] slang: make install-static do install-pkgconfig
Date: Sun, 13 Mar 2016 21:20:28 +0100	[thread overview]
Message-ID: <20160313202028.GA3488@free.fr> (raw)
In-Reply-To: <87mvq2gmo4.fsf@dell.be.48ers.dk>

Peter, All,

On 2016-03-13 21:14 +0100, Peter Korsgaard spake thusly:
> >>>>> "Max" == Max Filippov <jcmvbkbc@gmail.com> writes:
> 
>  > mc's configure can't find S-Lang because static S-Lang build doesn't
>  > install pkgconfig file into staging. Adding install-pkgconfig to
>  > install-static dependencies fixes that.
> 
>  > Fixes:
>  >   http://autobuild.buildroot.net/results/085194f18bc7db1e801d98e6620e3a75fd988cc5/
> 
>  > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>  > ---
>  >  package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch | 3 ++-
>  >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>  > diff --git a/package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch b/package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch
>  > index ee306a1..b0f8779 100644
> 
> Patch description and signed-off-by missing. Alternatively we can drop
> the patch and just pass install-pkgconfig to the 'make install' step as
> we already need to use a custom make target anyway.

That's what Max did in his first patch, and I asked him to do it in our
patch.
The .pc file is not installed for static-only because *we* added a patch
that breaks down install into install-staging and install-shared.

So it makes more sense to fix our own patch, that work around 
deficiencies we added.

Plus, it makes for a patch that can be more easily upstremable.

Regards,
Yann E. MORIN.

>  > --- a/package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch
>  > +++ b/package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch
>  > @@ -39,7 +39,8 @@ diff -rup a/autoconf/Makefile.in b/autoconf/Makefile.in
>  >   	cd slsh; $(MAKE) all
>  >  @@ -73,10 +76,11 @@ clean:
>  >   	cd demo; $(MAKE) clean
>  > - install-static:
>  > +-install-static:
>  > ++install-static: install-pkgconfig
>  >   	cd src; $(MAKE) install-static
>  >  +	cd slsh; $(MAKE) install-static
>  >   install-pkgconfig: slang.pc
>  > -- 
>  > 2.1.4
> 
>  > _______________________________________________
>  > buildroot mailing list
>  > buildroot at busybox.net
>  > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 
> -- 
> Bye, Peter Korsgaard

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2016-03-13 20:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13  3:06 [Buildroot] [PATCH] slang: make install-static do install-pkgconfig Max Filippov
2016-03-13 20:14 ` Peter Korsgaard
2016-03-13 20:17   ` Thomas Petazzoni
2016-03-13 20:43     ` Peter Korsgaard
2016-03-13 20:20   ` Yann E. MORIN [this message]
2016-03-13 20:44     ` Peter Korsgaard
2016-03-13 20:47       ` Yann E. MORIN
2016-03-13 20:20 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160313202028.GA3488@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.