From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/8] btrfs-progs: Basic framework for dedup command group
Date: Mon, 14 Mar 2016 10:21:24 +0100 [thread overview]
Message-ID: <20160314092124.GY18908@suse.cz> (raw)
In-Reply-To: <56E67DD8.6000409@cn.fujitsu.com>
On Mon, Mar 14, 2016 at 05:01:12PM +0800, Qu Wenruo wrote:
> Hi David,
>
> Just like the kernel naming change, does btrfs-progs also need to change
> 'dedup' to 'dedupe'?
Yes please.
> For kernel part, I have changed all 'dedup' to 'dedupe', including
> filename (dedup.c -> dedupe.c), function name and even comment.
>
> I'm a little curious about should btrfs-progs also keep the naming to
> dedupe.
>
> Like "btrfs dedupe enable" or "btrfs deduplication enable"?
I think nobody will want to type 'deduplication' :) The command names
can be shortened (as far as they're unique), so both ways will work
'dedup' and 'dedupe' and I don't think we'll ever add anything with the
same prefix 'dedup', so it should be safe.
prev parent reply other threads:[~2016-03-14 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 6:18 [PATCH 1/8] btrfs-progs: Basic framework for dedup command group Qu Wenruo
2016-02-18 6:18 ` [PATCH 2/8] btrfs-progs: dedup: Add enable command " Qu Wenruo
2016-02-18 6:18 ` [PATCH 3/8] btrfs-progs: dedup: Add disable support for inband deduplication Qu Wenruo
2016-02-18 6:18 ` [PATCH 4/8] btrfs-progs: dedup: Add status subcommand Qu Wenruo
2016-02-18 6:18 ` [PATCH 5/8] btrfs-progs: Add dedup feature for mkfs and convert Qu Wenruo
2016-02-18 6:18 ` [PATCH 6/8] btrfs-progs: Add show-super support for new DEDUP flag Qu Wenruo
2016-02-18 6:18 ` [PATCH 7/8] btrfs-progs: debug-tree: Add dedup tree support Qu Wenruo
2016-02-18 6:18 ` [PATCH 8/8] btrfs-progs: property: add a dedup property Qu Wenruo
2016-03-14 9:01 ` [PATCH 1/8] btrfs-progs: Basic framework for dedup command group Qu Wenruo
2016-03-14 9:21 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314092124.GY18908@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.