From: Thierry Reding <thierry.reding@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] i2c: i2c-core: do not use bus internal data
Date: Mon, 14 Mar 2016 10:39:04 +0100 [thread overview]
Message-ID: <20160314093904.GC27975@ulmo> (raw)
In-Reply-To: <20160314092809.GC1383@katana>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Mon, Mar 14, 2016 at 10:28:10AM +0100, Wolfram Sang wrote:
>
> > This doesn't work. I see a number of these WARN_ON()s trigger and I
> > think the reason is that i2c_init() always fails now. The cause seems to
> > be that i2c_init() calls i2c_add_driver(&dummy_driver), which will now
> > always fail, because is_register is set to true *after* that call. There
> > is no way I see I2C working at all after this patch.
>
> Same conclusion here. Too much trust applied to the original patch, mea
> culpa and sorry! Will send the fixup (tested!) in a minute.
No worries. There's nothing like good old runtime testing for making
sure things really do work. =)
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-14 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 11:49 [PATCH] i2c: i2c-core: do not use bus internal data Sudip Mukherjee
2016-03-07 16:57 ` Greg KH
2016-03-07 17:17 ` Sudip Mukherjee
2016-03-12 15:14 ` Wolfram Sang
2016-03-14 9:18 ` Thierry Reding
2016-03-14 9:27 ` Thierry Reding
2016-03-14 12:15 ` Sudeep Holla
2016-03-14 9:28 ` Wolfram Sang
2016-03-14 9:39 ` Thierry Reding [this message]
2016-03-14 14:25 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314093904.GC27975@ulmo \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.