From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afXIn-0001kh-VK for qemu-devel@nongnu.org; Mon, 14 Mar 2016 14:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afXIm-0008Ln-Pk for qemu-devel@nongnu.org; Mon, 14 Mar 2016 14:33:13 -0400 Date: Mon, 14 Mar 2016 18:33:03 +0000 From: "Daniel P. Berrange" Message-ID: <20160314183303.GL21198@redhat.com> References: <1456747261-22032-1-git-send-email-berrange@redhat.com> <1456747261-22032-19-git-send-email-berrange@redhat.com> <56E6FB77.4020908@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56E6FB77.4020908@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 18/26] tests: add output filter to python I/O tests helper Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Fam Zheng , qemu-devel@nongnu.org, qemu-block@nongnu.org On Mon, Mar 14, 2016 at 11:57:11AM -0600, Eric Blake wrote: > On 02/29/2016 05:00 AM, Daniel P. Berrange wrote: > > Add a 'log' method to iotests.py which prints messages to > > stdout, with optional filtering of data. Port over some > > standard filters for present in the shell common.filter > > code. > > I'm not sure what you meant by 'for present'. Nor am I :-) Perhaps I meant to say 'already present' > > > > Signed-off-by: Daniel P. Berrange > > --- > > tests/qemu-iotests/iotests.py | 25 ++++++++++++++++++++++++- > > 1 file changed, 24 insertions(+), 1 deletion(-) > > > > But the patch itself looks reasonable. > Reviewed-by: Eric Blake > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|