From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbcCNXJi (ORCPT ); Mon, 14 Mar 2016 19:09:38 -0400 Received: from mail-bl2on0105.outbound.protection.outlook.com ([65.55.169.105]:1104 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752005AbcCNXJf (ORCPT ); Mon, 14 Mar 2016 19:09:35 -0400 Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=ni.com; Date: Mon, 14 Mar 2016 17:36:23 -0500 From: Kyle Roeschley To: Josh Cartwright CC: Greg KH , , , , , , Lee Jones Subject: Re: [PATCH 1/2] misc: add nirtfeatures driver Message-ID: <20160314223622.GA20547@senary> References: <1457992472-18680-1-git-send-email-kyle.roeschley@ni.com> <20160314220559.GA18771@kroah.com> <20160314223022.GB22360@jcartwri.amer.corp.natinst.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160314223022.GB22360@jcartwri.amer.corp.natinst.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.218] X-ClientProxiedBy: SN1PR0701CA0028.namprd07.prod.outlook.com (25.162.96.38) To DM2PR0401MB0941.namprd04.prod.outlook.com (25.160.97.23) X-MS-Office365-Filtering-Correlation-Id: e7f91a25-18c2-4f0a-0955-08d34c590a4b X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB0941;2:IFVPw5NB6tyfwkxgEaeA2YpBZcdjxOKs02eoPHYbxPKHACJrwahdrBHE+KlTInLliDFgm6iqNmb24ARFiJjwXPyemTQ8i3Qbc2QKkQEavWI7zMi/xNBTCRXruABT41nfV5AZBvl2PZpj/bvmQWNiIik52IJEYXaMkkC94F7NAXcM11D7QgCCLAxxdETaSPkz;3:eYaqV4OJcH6QYt0GJRInAr2tWRDccC4QVflVsowydB+aVaaES3xAWqmZVMtE26YwWMnkVp2aKBtdntOrKCvh8SLusvxIibhGC1JntE9oCE+zVJcxTIywqJ30jyBFgeo/;25:Lu0ElU8JLEzBKCUdRcBjxlcH/e1RlL54kD7yPHjPlXP0P0SmIVoyg286How4kuYyXIi0VXSR6A/VRAprQdHTHvS28tcdvuAugS8CKfZ/0BYuOdBm5qjF+HJGuKeAKB+ZPrcYaiRgoqh8hfHsaXuI4+MTLRwJD7VC26ihwEetHEnmyv2OsOSFZsCHnghRsgNkkLUQO8GWKesteQBNcJIiJWCY0GuFyL1R4Iue5ZgioneXJUQhOUTP0iEFsE8RkEjf/ZJjar32XU6J/1JjF6Fv0kZW8EgwkXoVIMpjwPgfLU/xHr6tA82unHbbDh5V0lnNxFJDl83hATC5xGcCdPmfig== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0401MB0941; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB0941;20:GvMopedqSf3eZjh4dON/Vt4HBLMKLb6U86tB45ST68XBEI3RclvZJSztncQ/GA5pP0WzkLcN7fhu4QhTehmwThr0S/5RW5ZrGxhzZy8nPzXky71mKChgP3yC9K0Ybs0/DTAncLFBUui0UTJqTjFRzt1swb0EymoKfCPFuDRxNaYQLIu7KaXU4pdGTZWoSXlM/P17JXZfCfboMzb2oUX7Wk5oucQ9vw/toyNJlAilYsuigVWeat65GhVuWjwJeinxzWkErIIIgG/VB21Q4WkIDmKTuRkSE7MOb7slOrQARPbQfd/GCUDtWbwF+MNw0kWiRT+AAoaJzjBjEmOFp2nwgH106kEvM65GJsffzz6RTdrbRKP1lFCLoL7h4PBeLmyBbsXqHGkoa17FQ+ld2t4RnKTwWaJcUCABBckKA/sYidfBIYdkS0y7jUdj0NeFjJKqXh2qAi9BxgYvXHNIeGQWMRvRJWUNNZPeCSp7xNoTqjTyg4jn13F5I1g4vqnjKWIl4jhL2IFSkWgzLQMjZjgmlDz5i3+uEQb+Duvxt24EwTrF6/x/bBErc+a1sTvAqM0+TmHLMUXXrchC99lWyYcJRVpEMt7LiZ+ZoKHbtL+9nfo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DM2PR0401MB0941;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0401MB0941; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB0941;4:QQ8FJMlUYjkV9OJm6LgeoePVuXIunQRATHuYdSxJ5Tf8O7xNLBp8x4wxIu9nvqfWWcmBA0X+SNWx23rr+YqBj7rc9NrUgRWJT0AMQsfIXzl9Q9fRJqJ7uY2YTDqXQDco9x+2fUBx1OqLghnOvivr6IBoo04JsrkbRgnqKtNrh/TeMr/18hE4Jaxw2uxIoHH2DTuSf4Og7vw4ms5mO+8CZbtT++kny5qgnTKZ2vnVxoI4clQNB4cYniRldcmv4ne3+dW3HxXvqjG9qVouS2NqL0VSrdcfNymFdbua8m5/equyiNUwYusyJNmTcqhSNLKcJduUK+pQv/U4PQuWuEcMYqAWar0vOLi5krQ/Wph9+0ivryghjbMAtwT4cLz49FM3 X-Forefront-PRVS: 0881A7A935 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(24454002)(5008740100001)(33716001)(92566002)(86362001)(81166005)(97756001)(76176999)(46406003)(54356999)(77096005)(2950100001)(47776003)(4001350100001)(33656002)(110136002)(189998001)(50986999)(42186005)(19580405001)(19580395003)(23726003)(50466002)(1076002)(83506001)(1096002)(586003)(4326007)(2906002)(66066001)(6116002)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0401MB0941;H:senary;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB0941;23:s7aY9AySLdNyqv3wZ/pdO5po5id+/qqCP+qyY/h8vQiF7ogstFktWZt76vEdpImzokoFu9bk9to0Fb17foJJ54LvaokvkhmyLsMyLZexdJrF0U5dsql7uuFYMXb0M2RccVcJ77gX6TLjqSn7TpyPAJf8M2lY5Ie6nhPbLWqd/HZ7FmWjrJjM5mm5jGAJiA1Y/Aqu3xENNKN0cKKAvTs+WEA4opqJWK1xbEQyY0lkP31Dhg0tch9SozsjlT7AUiJFgbzZMOJB3wTRw/55NHLF4B5pLZUBhKyoJntrLgWciWdZKQrlrX0/w3jp/eOBpfy+cnYfGvqj+eEvq6i4v16wDDVStApBNeYb+Qj3lscmoJQjMLLOIjtgV2+TIRwdBc2RvelDmKspBJNyWu8zpgEmIE7VxvGBmpYLt8wokhZ1kDOmK1mH9NYQS/Evu7OfD0rITEKTf83zIW8eZeHBGAlJ1OVa8Ucz8i8zX0/5HIkrKAOWgqlhwUBldyzah6wvxmkEC96jIyBGO225dH5O/LB3QjdmaBQAys3Hxm8MODAj2eKrrESXoRBysEYrg4or4RfLuIlJQgzLKNu02+Y+3ldh/suhxLs+FUpYqHI2H/3hDJKUk/MWsreHvo83jnOH28jT6ObGo+BlxMm5LTQ1QZU7NQlKVeAoh0SZV+uw3T0lOgUwLjAr+oVN2uUlhk3lb9aodDLd6Ey3IrRRVy3wvoLQvB1B/3aSYZmPP6gMb7vhr4eJ4XMCxpaPt9EjjNMXfgfYq+zV6Lh5OKZWpLIn/mtQrWP2TLGhz0CCV+3h3KmEizyGggA2cmtjLbMp/KBgeTnN6nOxYVuZ0gwgzrP8dOUU8z8l1OqmXEkSKsKBPVvMIbbCKZi9wXMWiWcu4XehQNOoeuTN3NUnh4Xq+EQyWc4HzgCCMc/WPCyDycRoOu6oSWA= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB0941;5:r+3uAO1tOFORz67OlbQyTvtWn1Q59Zab27qv0NCMEky+sOM47/GZjFoRAPIqBmtytH/Y8eJECY6zkUSlH4C6p1hckvJrQcPXfzHqB0G7pSzvqPcXCQwy1OHBjlRKOF4rYX/kzTj4J13uonWwOVHm4Q==;24:ihMe2cNbhdJmQceDS43TTcVP05xWO0ZpCA35K2e4S3pQBGKQlzdclq7iPRxZ/CegvHqzmwYgK+1D3FwEfWOvShddRuJJiGRVthb59FidExE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 22:36:09.3174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0401MB0941 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2016 at 05:30:22PM -0500, Josh Cartwright wrote: > On Mon, Mar 14, 2016 at 03:05:59PM -0700, Greg KH wrote: > > On Mon, Mar 14, 2016 at 04:54:32PM -0500, Kyle Roeschley wrote: > > > From: Jeff Westfahl > > > > > > This driver introduces support for hardware features of National > > > Instruments real-time controllers. This is an ACPI device that exposes > > > LEDs, switches, and watchdogs. > > > > If it's an acpi driver, why not put it in drivers/acpi? > > For the same reason we don't move all drivers for devices-on-a-PCI-bus > into drivers/pci? > > Drivers typically exist in the sourcetree with other drivers which > implement similar functionality, which works great for devices with > clear functional boundaries (GPIO controller drivers in drivers/gpio, > led drivers in drivers/leds, etc. etc.); but for devices which are a > hodgepodge of functionality, there isn't really a good fit anywhere > except maybe in misc or mfd. > > We could move it to mfd, but drivers in drivers/mfd which don't make use > of MFD_CORE seems equally strange (although, I suppose there is > precedent). Maybe Lee has some thoughts. Maybe drivers/platform? I notice several ACPI drivers there that also have grab bags of functionality. Regards, Kyle Roeschley National Instruments