From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Adrian Alonso <aalonso@freescale.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: freescale: imx: fix bogus check of of_iomap() return value
Date: Tue, 15 Mar 2016 17:00:04 +0800 [thread overview]
Message-ID: <20160315090000.GA28207@tiger> (raw)
In-Reply-To: <1457484336-8928-1-git-send-email-vz@mleia.com>
On Wed, Mar 09, 2016 at 02:45:36AM +0200, Vladimir Zapolskiy wrote:
> On error path of_iomap() returns NULL, hence IS_ERR() check is invalid
> and may cause a NULL pointer dereference, the change fixes this
> problem.
>
> While we are here invert a device node check to simplify the code.
>
> Fixes: 26d8cde5260b ("pinctrl: freescale: imx: add shared input select reg support")
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
next prev parent reply other threads:[~2016-03-15 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 0:45 [PATCH] pinctrl: freescale: imx: fix bogus check of of_iomap() return value Vladimir Zapolskiy
2016-03-15 9:00 ` Shawn Guo [this message]
2016-03-16 12:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315090000.GA28207@tiger \
--to=shawnguo@kernel.org \
--cc=aalonso@freescale.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.