Re: [PATCH u-boot 3/5] net: aspeednic: Remove extra spaces before assignments

[Cyril Bur <cyrilbur@gmail.com>]

On Fri, 11 Mar 2016 12:40:42 -0600
OpenBMC Patches <openbmc-patches@stwcx.xyz> wrote:

> From: "Milton D. Miller II" <miltonm@us.ibm.com>
> 
> The device method assignments had extra spaces before the =
> signs but all prior methods were 4 characters and so they
> were aligned.  Since write_hwaddr is significantly longer,
> the resulting spacing is not pleasing.  Since only a few other
> sites had simiar whitespace replace all multi-space sequences
> before an assignemnt with one space.
> 
> Signed-off-by: Milton Miller <miltonm@us.ibm.com>

Reviewed-by: Cyril Bur <cyrilbur@gmail.com>

> ---
>  drivers/net/aspeednic.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/aspeednic.c b/drivers/net/aspeednic.c
> index 90c0f0d..841df8b 100644
> --- a/drivers/net/aspeednic.c
> +++ b/drivers/net/aspeednic.c
> @@ -560,10 +560,10 @@ int aspeednic_initialize(bd_t *bis)
>    *(volatile u_long *)(SCU_BASE + SCU_SCRATCH_REGISTER) = cpu_to_le32((SCURegister & ~(0x3000)) | (CONFIG_MAC2_PHY_SETTING << 12));
>  
>  
> -  dev->init   = aspeednic_init;
> -  dev->halt   = aspeednic_halt;
> -  dev->send   = aspeednic_send;
> -  dev->recv   = aspeednic_recv;
> +  dev->init = aspeednic_init;
> +  dev->halt = aspeednic_halt;
> +  dev->send = aspeednic_send;
> +  dev->recv = aspeednic_recv;
>    dev->write_hwaddr = aspeednic_write_hwaddr;
>  
>    /* Ensure we're not sleeping. */
> @@ -1267,9 +1267,9 @@ static int aspeednic_send(struct eth_device* dev, volatile void *packet, int len
>  //            memset ((void *)cpu_to_le32((u32) (packet + length)), 0, 60 - length);
>      length = 60;
>    }
> -  tx_ring[tx_new].buf    = cpu_to_le32(((u32) packet));
> -  tx_ring[tx_new].status   &= (~(0x3FFF));
> -  tx_ring[tx_new].status   |= cpu_to_le32(LTS | FTS | length);
> +  tx_ring[tx_new].buf = cpu_to_le32(((u32) packet));
> +  tx_ring[tx_new].status &= (~(0x3FFF));
> +  tx_ring[tx_new].status |= cpu_to_le32(LTS | FTS | length);
>    tx_ring[tx_new].status |= cpu_to_le32(TXDMA_OWN);
>  
>    OUTL(dev, POLL_DEMAND, TXPD_REG);
> @@ -1297,7 +1297,7 @@ static int aspeednic_send(struct eth_device* dev, volatile void *packet, int len
>  static int aspeednic_recv(struct eth_device* dev)
>  {
>    s32   status;
> -  int   length    = 0;
> +  int   length = 0;
>  
>    for ( ; ; )
>    {