From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/2] x86/hvm/viridian: keep APIC assist page mapped... Date: Tue, 15 Mar 2016 19:20:01 -0400 Message-ID: <20160315232001.GD29285@char.us.oracle.com> References: <1458058456-7345-1-git-send-email-paul.durrant@citrix.com> <1458058456-7345-2-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1afyG0-0002p0-7G for xen-devel@lists.xenproject.org; Tue, 15 Mar 2016 23:20:08 +0000 Content-Disposition: inline In-Reply-To: <1458058456-7345-2-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Keir Fraser , Jan Beulich , Andrew Cooper List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMTUsIDIwMTYgYXQgMDQ6MTQ6MTVQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+IC4uLiBmb3IgdGhlIGxpZmV0aW1lIG9mIHRoZSBkb21haW4uCj4gCj4gSWYgWGVuIGlz IHRvIG1ha2UgdXNlIG9mIHRoZSBBUElDIGFzc2lzdCBlbmxpZ2h0ZW5tZW50IHRoZW4gYSBwZXJz aXN0ZW50Cj4gbWFwcGluZyBuZWVkcyB0byBiZSBrZXB0LCByYXRoZXIgdGhhbiB0aGUgdGVtcG9y YXJ5IG9uZSB3aGljaCBpcyBjdXJyZW50bHkKPiB1c2VkIG9ubHkgdG8gaW5pdGlhbGl6ZSB0aGUg cGFnZSBjb250ZW50Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJy YW50QGNpdHJpeC5jb20+Cj4gQ2M6IEtlaXIgRnJhc2VyIDxrZWlyQHhlbi5vcmc+Cj4gQ2M6IEph biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KPiBDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KPiAtLS0KPiAgeGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi5j ICAgICAgICB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIHhl bi9pbmNsdWRlL2FzbS14ODYvaHZtL3ZpcmlkaWFuLmggfCAgNiArKysrLQo+ICAyIGZpbGVzIGNo YW5nZWQsIDQzIGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFu LmMKPiBpbmRleCA2YmQ4NDRiLi5jNzc5MjkwIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9o dm0vdmlyaWRpYW4uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdmlyaWRpYW4uYwo+IEBAIC0x NjMsNyArMTYzLDcgQEAgc3RhdGljIHZvaWQgZHVtcF9hcGljX2Fzc2lzdChjb25zdCBzdHJ1Y3Qg dmNwdSAqdikKPiAgewo+ICAgICAgY29uc3QgdW5pb24gdmlyaWRpYW5fYXBpY19hc3Npc3QgKmFh Owo+ICAKPiAtICAgIGFhID0gJnYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3Q7 Cj4gKyAgICBhYSA9ICZ2LT5hcmNoLmh2bV92Y3B1LnZpcmlkaWFuLmFwaWNfYXNzaXN0Lm1zcjsK PiAgCj4gICAgICBwcmludGsoWEVOTE9HX0dfSU5GTyAiJXB2OiBWSVJJRElBTiBBUElDX0FTU0lT VDogZW5hYmxlZDogJXggcGZuOiAlbHhcbiIsCj4gICAgICAgICAgICAgdiwgYWEtPmZpZWxkcy5l bmFibGVkLCAodW5zaWduZWQgbG9uZylhYS0+ZmllbGRzLnBmbik7Cj4gQEAgLTIxNyw5ICsyMTcs OSBAQCBzdGF0aWMgdm9pZCBlbmFibGVfaHlwZXJjYWxsX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCkK PiAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZV9hcGljX2Fzc2lzdChzdHJ1Y3QgdmNwdSAqdikKPiAg ewo+ICAgICAgc3RydWN0IGRvbWFpbiAqZCA9IHYtPmRvbWFpbjsKPiAtICAgIHVuc2lnbmVkIGxv bmcgZ21mbiA9IHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3QuZmllbGRzLnBm bjsKPiArICAgIHVuc2lnbmVkIGxvbmcgZ21mbiA9IHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4u YXBpY19hc3Npc3QubXNyLmZpZWxkcy5wZm47Cj4gICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdl ID0gZ2V0X3BhZ2VfZnJvbV9nZm4oZCwgZ21mbiwgTlVMTCwgUDJNX0FMTE9DKTsKPiAtICAgIHVp bnQ4X3QgKnA7Cj4gKyAgICB2b2lkICp2YTsKPiAgCj4gICAgICAvKgo+ICAgICAgICogV2UgZG9u J3QgeWV0IG1ha2UgdXNlIG9mIHRoZSBBUElDIGFzc2lzdCBwYWdlIGJ1dCBieSBzZXR0aW5nCj4g QEAgLTIzMSwyMSArMjMxLDQwIEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVfYXBpY19hc3Npc3Qo c3RydWN0IHZjcHUgKnYpCj4gICAgICAgKiBkZXRhaWxzIG9mIGhvdyBXaW5kb3dzIHVzZXMgdGhl IHBhZ2UuCj4gICAgICAgKi8KPiAgCj4gLSAgICBpZiAoICFwYWdlIHx8ICFnZXRfcGFnZV90eXBl KHBhZ2UsIFBHVF93cml0YWJsZV9wYWdlKSApCj4gKyAgICBpZiAoICFwYWdlICkKPiArICAgICAg ICByZXR1cm47Cj4gKwo+ICsgICAgaWYgKCAhZ2V0X3BhZ2VfdHlwZShwYWdlLCBQR1Rfd3JpdGFi bGVfcGFnZSkgKQo+ICAgICAgewo+IC0gICAgICAgIGlmICggcGFnZSApCj4gLSAgICAgICAgICAg IHB1dF9wYWdlKHBhZ2UpOwo+IC0gICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLCAiQmFk IEdNRk4gJWx4IChNRk4gJWx4KVxuIiwgZ21mbiwKPiAtICAgICAgICAgICAgICAgICBwYWdlID8g cGFnZV90b19tZm4ocGFnZSkgOiBJTlZBTElEX01GTik7Cj4gKyAgICAgICAgcHV0X3BhZ2UocGFn ZSk7CgpZb3UgZG9uJ3Qgd2FudCB0byByZXBvcnQgZXJyb3JzIGluIGNhc2UgdGhpcyBnb2VzIHNv dXRoPwoKPiAgICAgICAgICByZXR1cm47Cj4gICAgICB9Cj4gIAo+IC0gICAgcCA9IF9fbWFwX2Rv bWFpbl9wYWdlKHBhZ2UpOwo+ICsgICAgdmEgPSBfX21hcF9kb21haW5fcGFnZV9nbG9iYWwocGFn ZSk7Cj4gKyAgICBpZiAoICF2YSApCj4gKyAgICB7Cj4gKyAgICAgICAgcHV0X3BhZ2VfYW5kX3R5 cGUocGFnZSk7Cj4gKyAgICAgICAgcmV0dXJuOwo+ICsgICAgfQo+ICAKPiAtICAgICoodTMyICop cCA9IDA7Cj4gKyAgICAqKHVpbnQzMl90ICopdmEgPSAwOwo+ICAKPiAtICAgIHVubWFwX2RvbWFp bl9wYWdlKHApOwo+ICsgICAgdi0+YXJjaC5odm1fdmNwdS52aXJpZGlhbi5hcGljX2Fzc2lzdC5w YWdlID0gcGFnZTsKPiArICAgIHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3Qu dmEgPSB2YTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgdGVhcmRvd25fYXBpY19hc3Npc3Qoc3Ry dWN0IHZjcHUgKnYpCj4gK3sKPiArICAgIHN0cnVjdCBwYWdlX2luZm8gKnBhZ2UgPSB2LT5hcmNo Lmh2bV92Y3B1LnZpcmlkaWFuLmFwaWNfYXNzaXN0LnBhZ2U7Cj4gKyAgICB2b2lkICp2YSA9IHYt PmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3QudmE7Cj4gKwo+ICsgICAgaWYgKCAh dmEgKQo+ICsgICAgICAgIHJldHVybjsKPiArCj4gKyAgICB2LT5hcmNoLmh2bV92Y3B1LnZpcmlk aWFuLmFwaWNfYXNzaXN0LnZhID0gTlVMTDsKPiArICAgIHYtPmFyY2guaHZtX3ZjcHUudmlyaWRp YW4uYXBpY19hc3Npc3QucGFnZSA9IE5VTEw7Cj4gIAo+ICsgICAgdW5tYXBfZG9tYWluX3BhZ2Vf Z2xvYmFsKHZhKTsKPiAgICAgIHB1dF9wYWdlX2FuZF90eXBlKHBhZ2UpOwo+ICB9Cj4gIAo+IEBA IC0zNzQsOSArMzkzLDkgQEAgaW50IHdybXNyX3ZpcmlkaWFuX3JlZ3ModWludDMyX3QgaWR4LCB1 aW50NjRfdCB2YWwpCj4gIAo+ICAgICAgY2FzZSBWSVJJRElBTl9NU1JfQVBJQ19BU1NJU1Q6Cj4g ICAgICAgICAgcGVyZmNfaW5jcihtc2h2X3dybXNyX2FwaWNfbXNyKTsKPiAtICAgICAgICB2LT5h cmNoLmh2bV92Y3B1LnZpcmlkaWFuLmFwaWNfYXNzaXN0LnJhdyA9IHZhbDsKPiArICAgICAgICB2 LT5hcmNoLmh2bV92Y3B1LnZpcmlkaWFuLmFwaWNfYXNzaXN0Lm1zci5yYXcgPSB2YWw7Cj4gICAg ICAgICAgZHVtcF9hcGljX2Fzc2lzdCh2KTsKPiAtICAgICAgICBpZiAodi0+YXJjaC5odm1fdmNw dS52aXJpZGlhbi5hcGljX2Fzc2lzdC5maWVsZHMuZW5hYmxlZCkKPiArICAgICAgICBpZiAoIHYt PmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3QubXNyLmZpZWxkcy5lbmFibGVkICkK PiAgICAgICAgICAgICAgaW5pdGlhbGl6ZV9hcGljX2Fzc2lzdCh2KTsKPiAgICAgICAgICBicmVh azsKPiAgCj4gQEAgLTQ4NSw3ICs1MDQsNyBAQCBpbnQgcmRtc3JfdmlyaWRpYW5fcmVncyh1aW50 MzJfdCBpZHgsIHVpbnQ2NF90ICp2YWwpCj4gIAo+ICAgICAgY2FzZSBWSVJJRElBTl9NU1JfQVBJ Q19BU1NJU1Q6Cj4gICAgICAgICAgcGVyZmNfaW5jcihtc2h2X3JkbXNyX2FwaWNfbXNyKTsKPiAt ICAgICAgICAqdmFsID0gdi0+YXJjaC5odm1fdmNwdS52aXJpZGlhbi5hcGljX2Fzc2lzdC5yYXc7 Cj4gKyAgICAgICAgKnZhbCA9IHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3Qu bXNyLnJhdzsKPiAgICAgICAgICBicmVhazsKPiAgCj4gICAgICBjYXNlIFZJUklESUFOX01TUl9S RUZFUkVOQ0VfVFNDOgo+IEBAIC01MzAsNiArNTQ5LDcgQEAgaW50IHZpcmlkaWFuX3ZjcHVfaW5p dChzdHJ1Y3QgdmNwdSAqdikKPiAgdm9pZCB2aXJpZGlhbl92Y3B1X2RlaW5pdChzdHJ1Y3QgdmNw dSAqdikKPiAgewo+ICAgICAgZnJlZV9jcHVtYXNrX3Zhcih2LT5hcmNoLmh2bV92Y3B1LnZpcmlk aWFuLmZsdXNoX2NwdW1hc2spOwo+ICsgICAgdGVhcmRvd25fYXBpY19hc3Npc3Qodik7Cj4gIH0K PiAgCj4gIGludCB2aXJpZGlhbl9oeXBlcmNhbGwoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3Mp Cj4gQEAgLTcyOCw3ICs3NDgsNyBAQCBzdGF0aWMgaW50IHZpcmlkaWFuX3NhdmVfdmNwdV9jdHh0 KHN0cnVjdCBkb21haW4gKmQsIGh2bV9kb21haW5fY29udGV4dF90ICpoKQo+ICAgICAgZm9yX2Vh Y2hfdmNwdSggZCwgdiApIHsKPiAgICAgICAgICBzdHJ1Y3QgaHZtX3ZpcmlkaWFuX3ZjcHVfY29u dGV4dCBjdHh0Owo+ICAKPiAtICAgICAgICBjdHh0LmFwaWNfYXNzaXN0ID0gdi0+YXJjaC5odm1f dmNwdS52aXJpZGlhbi5hcGljX2Fzc2lzdC5yYXc7Cj4gKyAgICAgICAgY3R4dC5hcGljX2Fzc2lz dCA9IHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3QubXNyLnJhdzsKPiAgCj4g ICAgICAgICAgaWYgKCBodm1fc2F2ZV9lbnRyeShWSVJJRElBTl9WQ1BVLCB2LT52Y3B1X2lkLCBo LCAmY3R4dCkgIT0gMCApCj4gICAgICAgICAgICAgIHJldHVybiAxOwo+IEBAIC03NTQsNyArNzc0 LDkgQEAgc3RhdGljIGludCB2aXJpZGlhbl9sb2FkX3ZjcHVfY3R4dChzdHJ1Y3QgZG9tYWluICpk LCBodm1fZG9tYWluX2NvbnRleHRfdCAqaCkKPiAgICAgIGlmICggaHZtX2xvYWRfZW50cnkoVklS SURJQU5fVkNQVSwgaCwgJmN0eHQpICE9IDAgKQo+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ ICAKPiAtICAgIHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Npc3QucmF3ID0gY3R4 dC5hcGljX2Fzc2lzdDsKPiArICAgIHYtPmFyY2guaHZtX3ZjcHUudmlyaWRpYW4uYXBpY19hc3Np c3QubXNyLnJhdyA9IGN0eHQuYXBpY19hc3Npc3Q7Cj4gKyAgICBpZiAoIHYtPmFyY2guaHZtX3Zj cHUudmlyaWRpYW4uYXBpY19hc3Npc3QubXNyLmZpZWxkcy5lbmFibGVkICkKPiArICAgICAgICBp bml0aWFsaXplX2FwaWNfYXNzaXN0KHYpOwo+ICAKPiAgICAgIHJldHVybiAwOwo+ICB9Cj4gZGlm ZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3ZpcmlkaWFuLmggYi94ZW4vaW5jbHVk ZS9hc20teDg2L2h2bS92aXJpZGlhbi5oCj4gaW5kZXggMmVlYzg1ZS4uYzYwYzExMyAxMDA2NDQK PiAtLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS92aXJpZGlhbi5oCj4gKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9odm0vdmlyaWRpYW4uaAo+IEBAIC0yMSw3ICsyMSwxMSBAQCB1bmlvbiB2 aXJpZGlhbl9hcGljX2Fzc2lzdAo+ICAKPiAgc3RydWN0IHZpcmlkaWFuX3ZjcHUKPiAgewo+IC0g ICAgdW5pb24gdmlyaWRpYW5fYXBpY19hc3Npc3QgYXBpY19hc3Npc3Q7Cj4gKyAgICBzdHJ1Y3Qg ewo+ICsgICAgICAgIHVuaW9uIHZpcmlkaWFuX2FwaWNfYXNzaXN0IG1zcjsKPiArICAgICAgICBz dHJ1Y3QgcGFnZV9pbmZvICpwYWdlOwo+ICsgICAgICAgIHZvaWQgKnZhOwo+ICsgICAgfSBhcGlj X2Fzc2lzdDsKPiAgICAgIGNwdW1hc2tfdmFyX3QgZmx1c2hfY3B1bWFzazsKPiAgfTsKPiAgCj4g LS0gCj4gMi4xLjQKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBYZW4tZGV2ZWxAbGlzdHMueGVu Lm9yZwo+IGh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK