From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: [PATCH v2 20/22] atari_scsi: Set a reasonable default for cmd_per_lun Date: Wed, 16 Mar 2016 14:19:01 +1100 Message-ID: <20160316031846.961758222@telegraphics.com.au> References: <20160316031841.911913894@telegraphics.com.au> Return-path: Content-Disposition: inline; filename=atari_scsi-cmd_per_lun Sender: linux-kernel-owner@vger.kernel.org To: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ondrej Zary , Sam Creasey List-Id: linux-m68k@vger.kernel.org This setting does not need to be conditional on Atari ST or TT. Signed-off-by: Finn Thain --- Changed since v1: - Set the default cmd_per_lun to 4 based on test results. --- drivers/scsi/atari_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux/drivers/scsi/atari_scsi.c =================================================================== --- linux.orig/drivers/scsi/atari_scsi.c 2016-03-16 14:18:27.000000000 +1100 +++ linux/drivers/scsi/atari_scsi.c 2016-03-16 14:18:36.000000000 +1100 @@ -752,6 +752,7 @@ static struct scsi_host_template atari_s .eh_abort_handler = atari_scsi_abort, .eh_bus_reset_handler = atari_scsi_bus_reset, .this_id = 7, + .cmd_per_lun = 4, .use_clustering = DISABLE_CLUSTERING, .cmd_size = NCR5380_CMD_SIZE, }; @@ -788,11 +789,9 @@ static int __init atari_scsi_probe(struc */ if (ATARIHW_PRESENT(TT_SCSI)) { atari_scsi_template.can_queue = 16; - atari_scsi_template.cmd_per_lun = 8; atari_scsi_template.sg_tablesize = SG_ALL; } else { atari_scsi_template.can_queue = 8; - atari_scsi_template.cmd_per_lun = 1; atari_scsi_template.sg_tablesize = SG_NONE; } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965840AbcCPDbK (ORCPT ); Tue, 15 Mar 2016 23:31:10 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:36519 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965233AbcCPDax (ORCPT ); Tue, 15 Mar 2016 23:30:53 -0400 Message-Id: <20160316031846.961758222@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Wed, 16 Mar 2016 14:19:01 +1100 From: Finn Thain To: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , , , Cc: Ondrej Zary , Sam Creasey Subject: [PATCH v2 20/22] atari_scsi: Set a reasonable default for cmd_per_lun References: <20160316031841.911913894@telegraphics.com.au> Content-Disposition: inline; filename=atari_scsi-cmd_per_lun Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This setting does not need to be conditional on Atari ST or TT. Signed-off-by: Finn Thain --- Changed since v1: - Set the default cmd_per_lun to 4 based on test results. --- drivers/scsi/atari_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux/drivers/scsi/atari_scsi.c =================================================================== --- linux.orig/drivers/scsi/atari_scsi.c 2016-03-16 14:18:27.000000000 +1100 +++ linux/drivers/scsi/atari_scsi.c 2016-03-16 14:18:36.000000000 +1100 @@ -752,6 +752,7 @@ static struct scsi_host_template atari_s .eh_abort_handler = atari_scsi_abort, .eh_bus_reset_handler = atari_scsi_bus_reset, .this_id = 7, + .cmd_per_lun = 4, .use_clustering = DISABLE_CLUSTERING, .cmd_size = NCR5380_CMD_SIZE, }; @@ -788,11 +789,9 @@ static int __init atari_scsi_probe(struc */ if (ATARIHW_PRESENT(TT_SCSI)) { atari_scsi_template.can_queue = 16; - atari_scsi_template.cmd_per_lun = 8; atari_scsi_template.sg_tablesize = SG_ALL; } else { atari_scsi_template.can_queue = 8; - atari_scsi_template.cmd_per_lun = 1; atari_scsi_template.sg_tablesize = SG_NONE; }