From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator: Don't print error in devm_regulator_bulk_get() on -EPROBE_DEFER
Date: Wed, 16 Mar 2016 09:59:46 +0000 [thread overview]
Message-ID: <20160316095946.GR2566@sirena.org.uk> (raw)
In-Reply-To: <1458074114-8088-1-git-send-email-javier@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Tue, Mar 15, 2016 at 05:35:14PM -0300, Javier Martinez Canillas wrote:
> The regulators may not be available just because their driver's probe was
> not executed and the regulators were not registered yet. So don't print an
> error in this case to avoid polluting the kernel log and confuse the users.
We've been through this repeatedly - this is the case for all probe
deferrals and if we just don't print the errors at all then people won't
be able to tell if they've got a missing dependency. We need people to
work on things like allowing the kernel to make use of the dependency
information it has to order probes more sensibly.
Raphael had some ideas he was talking about at Kernel Summit for this,
Russell King also proposed just suppressing the errors until we're at
the last deferred probe run at the end of init.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-16 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 20:35 [PATCH] regulator: Don't print error in devm_regulator_bulk_get() on -EPROBE_DEFER Javier Martinez Canillas
2016-03-16 9:59 ` Mark Brown [this message]
2016-03-16 11:19 ` Javier Martinez Canillas
2016-03-16 11:37 ` Mark Brown
2016-03-16 11:40 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316095946.GR2566@sirena.org.uk \
--to=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.