From: Pavel Machek <pavel@denx.de>
To: pavel@denx.de
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com,
grant.likely@linaro.org, robh+dt@kernel.org
Subject: spurious warning from of_i2c_register_device with fixed_regulator?
Date: Wed, 16 Mar 2016 12:01:56 +0100 [thread overview]
Message-ID: <20160316110156.GC21259@amd> (raw)
Hi!
We are getting this in the logs:
i2c i2c-0: of_i2c: invalid reg on /soc/i2c@ffc04000/vcc3p3-regulator
In the dts we have:
socfpga_cyclone5_sockit.dts:
regulator_3_3v: vcc3p3-regulator {
compatible = "regulator-fixed";
regulator-name = "VCC3P3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};
Which seems to trigger
drivers/i2c/i2c-core.c:
addr_be = of_get_property(node, "reg", &len);
if (!addr_be || (len < sizeof(*addr_be))) {
dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",
...
But we have fixed regulator there, it does not have "reg" property.
Git blame says: a430a3455f2c48995e06b359a82a1109a419e9ef. (And no, I
don't have exactly mainline kernel here, but it should be close enough.)
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2016-03-16 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:01 Pavel Machek [this message]
2016-03-16 11:20 ` spurious warning from of_i2c_register_device with fixed_regulator? Wolfram Sang
2016-03-23 11:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316110156.GC21259@amd \
--to=pavel@denx.de \
--cc=grant.likely@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.