From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Can't git stash after using git add -N
Date: Wed, 16 Mar 2016 05:02:45 -0700 [thread overview]
Message-ID: <20160316120245.GA15091@cloud> (raw)
In-Reply-To: <xmqqvb4n58ko.fsf@gitster.mtv.corp.google.com>
On Tue, Mar 15, 2016 at 09:51:35PM -0700, Junio C Hamano wrote:
> Josh Triplett <josh@joshtriplett.org> writes:
>
> > As far as I can tell, if I run "git add -N" on a file, and then commit
> > without adding the file contents, it gets committed as an empty file.
>
> Is that true? Git once worked like that in earlier days, but I
> think write-tree (hence commit) would simply ignore intent-to-add
> entries from its resulting tree.
Git 2.7.0 does appear to commit an empty file if I commit after git add
-N.
> > Could stash save it exactly as if I'd done "git add" of an empty file at
> > that path and then filled in the contents without adding them?
>
> As I said, there is no space for a tree object to say "this one
> records an empty blob but it actually was an intent-to-add entry"
> and "this other one records an empty blob and it indeed is an empty
> blob". So "stash pop" (or "stash apply") would fundamentally be
> unable to resurrect the exact state after "add -N".
How completely crazy would it be to use a non-standard mode bit for
that?
> >> "git rm --cached" the path and then running "stash save" would be a
> >> workaround, but then you'd probably need to use "--untracked" hack
> >> when you run "stash save" if you are stashing because you are going
> >> to do something to the same path in the cleaned-up working tree.
> >
> > Right; I do specifically want to save the working-tree files.
>
> Then "git add" that path before "stash save" would probably be a
> better workaround.
I ended up using rm --cached and stash -u, which worked OK, though I
then had to manually restore the add -N state.
next prev parent reply other threads:[~2016-03-16 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 23:07 Can't git stash after using git add -N Josh Triplett
2016-03-15 23:46 ` Junio C Hamano
2016-03-16 2:00 ` Josh Triplett
2016-03-16 4:51 ` Junio C Hamano
2016-03-16 11:09 ` Duy Nguyen
2016-03-16 12:02 ` Josh Triplett [this message]
2016-03-16 21:05 ` Jeff King
2016-03-16 21:11 ` Junio C Hamano
2016-03-16 21:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316120245.GA15091@cloud \
--to=josh@joshtriplett.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.