Re: [PATCH v2 5/5] mlx5: add VLAN insertion offload

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Fri, Mar 11, 2016 at 03:24:43PM +0000, Bruce Richardson wrote:
> On Thu, Mar 03, 2016 at 03:27:59PM +0100, Adrien Mazarguil wrote:
> > From: Yaacov Hazan <yaacovh@mellanox.com>
> > 
> > VLAN insertion is done in software by the PMD by default unless
> > CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION is enabled and Verbs provides
> > support for hardware insertion.
> > 
> > When enabled, this option improves performance when VLAN insertion is
> > requested, however ConnectX-4 Lx boards cannot take advantage of
> > multi-packet send optimizations anymore.
> > 
> > Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > ---
> >  config/common_linuxapp                 |   1 +
> >  doc/guides/nics/mlx5.rst               |   9 +++
> >  doc/guides/rel_notes/release_16_04.rst |   6 ++
> >  drivers/net/mlx5/Makefile              |   9 +++
> >  drivers/net/mlx5/mlx5_defs.h           |   9 +++
> >  drivers/net/mlx5/mlx5_ethdev.c         |  12 ++--
> >  drivers/net/mlx5/mlx5_rxtx.c           | 109 +++++++++++++++++++++++++++------
> >  drivers/net/mlx5/mlx5_rxtx.h           |  13 ++++
> >  drivers/net/mlx5/mlx5_txq.c            |  15 ++++-
> >  9 files changed, 158 insertions(+), 25 deletions(-)
> > 
> > diff --git a/config/common_linuxapp b/config/common_linuxapp
> > index 7b5e49f..793d262 100644
> > --- a/config/common_linuxapp
> > +++ b/config/common_linuxapp
> > @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n
> >  CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N=4
> >  CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE=0
> >  CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8
> > +CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION=n
> >
> New build time configuration options are no longer allowed in DPDK, as they can't
> be used in binary distributions and make testing harder. This should be made
> a run-time option instead.

OK, it was done as a performance improvement for a specific case, I will
submit an updated patchset without this option.

-- 
Adrien Mazarguil
6WIND