Re: [PATCH v7 for Xen 4.7 4/4] xl: enable per-VCPU parameter settings for RTDS scheduler

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Mar 16, 2016 at 07:24:35PM +0000, Wei Liu wrote:
> On Wed, Mar 16, 2016 at 11:47:51AM -0500, Chong Li wrote:
> > ---
> >  docs/man/xl.pod.1         |  38 ++++++
> >  tools/libxl/xl_cmdimpl.c  | 301 +++++++++++++++++++++++++++++++++++++++++-----
> >  tools/libxl/xl_cmdtable.c |  16 ++-
> >  3 files changed, 320 insertions(+), 35 deletions(-)
> > 
> > diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> > index 4279c7c..1a8aacd 100644
> > --- a/docs/man/xl.pod.1
> > +++ b/docs/man/xl.pod.1
> > @@ -1051,6 +1051,10 @@ B<OPTIONS>
> >  Specify domain for which scheduler parameters are to be modified or retrieved.
> >  Mandatory for modifying scheduler parameters.
> >  
> > +=item B<-v VCPUID/all>, B<--vcpuid=VCPUID/all>
> > +
> > +Specify vcpu for which scheduler parameters are to be modified or retrieved.
> > +
> >  =item B<-p PERIOD>, B<--period=PERIOD>
> >  
> >  Period of time, in microseconds, over which to replenish the budget.
> > @@ -1066,6 +1070,40 @@ Restrict output to domains in the specified cpupool.
> >  
> >  =back
> >  
> > +B<EXAMPLES>
> > +
> > +=over 4
> > +
> > +=item B<-d [domid]>
> > +
> > +List default per-domain params for a domain
> > +
> > +=item B<-d [domid] [params (period and budget)]>
> > +
> > +Set per-domain params for a domain
> > +
> > +=item B<-d [domid] -v [vcpuid] -v [vcpuid] ...>
> > +
> > +List per-VCPU params for a domain
> > +
> > +=item B<-d [domid] -v all>
> > +
> > +List all per-VCPU params for a domain
> > +
> > +=item B<-v all>
> > +
> > +List all per-VCPU params for all domains
> > +
> > +=item B<-d [domid] -v [vcpuid] [params] -v [vcpuid] [params] ...>
> > +
> > +Set per-VCPU params for a domain
> > +
> > +=item B<-d [domid] -v all [params]>
> > +
> > +Set all per-VCPU params for a domain
> > +
> > +=back
> > +
> 
> Urgh, there might be some misunderstanding here. These are explanations
> to specific commands, while I asked for some concrete examples.
> 
> Search for "example" in xl manpage.
> 

BTW I think you just need to move some of the examples in your cover
letter to manpage.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel