From: Steffen Klassert <steffen.klassert@secunet.com>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] xfrm: don't segment UFO packets
Date: Thu, 17 Mar 2016 11:24:59 +0100 [thread overview]
Message-ID: <20160317102459.GG3347@gauss.secunet.com> (raw)
In-Reply-To: <20160317094115.GA11706@midget.suse.cz>
On Thu, Mar 17, 2016 at 10:41:15AM +0100, Jiri Bohac wrote:
> On Thu, Mar 17, 2016 at 01:03:59PM +0800, Herbert Xu wrote:
> > On Wed, Mar 16, 2016 at 05:00:26PM +0100, Jiri Bohac wrote:
> > > Prevent xfrm_output() from segmenting UFO packets so that they will be
> > > fragmented after the xfrm transforms.
> >
> > Fair enough. But I wonder if this is enough. Wouldn't UDP notice
> > that we're doing IPsec and prefragment the packet anyway? So I think
> > this check may also be needed in the UDP output path.
>
> Fixes my broken case.
Is this IPv4 or IPv6? IPv4 should not create a GSO skb
if IPsec is done. It checks for rt->dst.header_len
in __ip_append_data() and does a fallback to the
standard case if rt->dst.header_len is non zero.
In IPv6 this check is missing, so this could be the
problem if this is IPv6.
next prev parent reply other threads:[~2016-03-17 10:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 23:44 xfrm: UFO + ESP = double fragmentation Jiri Bohac
2016-01-30 4:21 ` Herbert Xu
2016-03-16 16:00 ` [PATCH] xfrm: don't segment UFO packets Jiri Bohac
2016-03-17 5:03 ` Herbert Xu
2016-03-17 9:41 ` Jiri Bohac
2016-03-17 10:24 ` Steffen Klassert [this message]
2016-03-17 10:49 ` Jiri Bohac
2016-03-17 11:01 ` Steffen Klassert
2016-03-17 17:08 ` Jiri Bohac
2016-03-18 2:36 ` Herbert Xu
2016-03-18 8:05 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317102459.GG3347@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.