All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] raptor: new package
Date: Thu, 17 Mar 2016 13:58:20 +0200	[thread overview]
Message-ID: <20160317115820.GI5528@tarshish> (raw)
In-Reply-To: <1458214161-17159-1-git-send-email-nitin.mendiratta@rockwellcollins.com>

Hi Nitin,

On Thu, Mar 17, 2016 at 04:59:21PM +0530, Nitin Mendiratta wrote:
> From: Matt Weber <matthew.weber@rockwellcollins.com>
> 
> Raptor is a free software / Open Source C library that provides a set of parsers
> and serializers that generate Resource Description Framework (RDF) triples
> by parsing syntaxes or serialize the triples into a syntax.
> 
> http://librdf.org/raptor/
> 
> Patch added in the package:
> 0001-configure.ac-remove-conditional-lib-inclusion.patch
> 
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> 
> ---
> Changes v1:
>   - Added 0001-configure.ac-remove-conditional-lib-inclusion.patch.
>   - Added optional dependencies libcurl,yajl and icu.
> 
> Signed-off-by: Nitin Mendiratta <nitin.mendiratta@rockwellcollins.com>

Your sign-off should be above the --- separator just below Matt's. Otherwise 
it won't appear in the commit log when this patch applies using 'git am'.

> ---
>  package/Config.in                                  |  1 +
>  ...igure.ac-remove-conditional-lib-inclusion.patch | 20 +++++++++++++++
>  package/raptor/Config.in                           | 11 ++++++++
>  package/raptor/raptor.hash                         |  2 ++
>  package/raptor/raptor.mk                           | 30 ++++++++++++++++++++++
>  5 files changed, 64 insertions(+)
>  create mode 100644 package/raptor/0001-configure.ac-remove-conditional-lib-inclusion.patch
>  create mode 100644 package/raptor/Config.in
>  create mode 100644 package/raptor/raptor.hash
>  create mode 100644 package/raptor/raptor.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index c4d98c4..430cef8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1036,6 +1036,7 @@ menu "JSON/XML"
>  	source "package/mxml/Config.in"
>  	source "package/rapidjson/Config.in"
>  	source "package/rapidxml/Config.in"
> +	source "package/raptor/Config.in"
>  	source "package/tinyxml/Config.in"
>  	source "package/tinyxml2/Config.in"
>  	source "package/xerces/Config.in"
> diff --git a/package/raptor/0001-configure.ac-remove-conditional-lib-inclusion.patch b/package/raptor/0001-configure.ac-remove-conditional-lib-inclusion.patch
> new file mode 100644
> index 0000000..0fd0495
> --- /dev/null
> +++ b/package/raptor/0001-configure.ac-remove-conditional-lib-inclusion.patch
> @@ -0,0 +1,20 @@
> +Removed condition for header path inclusion from the configure file.

You should mention here that this include path is from the host, which is 
wrong for cross compilation.

[snip]

> diff --git a/package/raptor/raptor.mk b/package/raptor/raptor.mk
> new file mode 100644
> index 0000000..965ef0c
> --- /dev/null
> +++ b/package/raptor/raptor.mk
> @@ -0,0 +1,30 @@
> +################################################################################
> +#
> +# raptor
> +#
> +################################################################################
> +
> +RAPTOR_VERSION = 2.0.15
> +RAPTOR_SOURCE = raptor2-$(RAPTOR_VERSION).tar.gz
> +RAPTOR_SITE = http://download.librdf.org/source
> +RAPTOR_DEPENDENCIES = libxml2 libxslt
> +RAPTOR_LICENSE = GPLv2+ or LGPLv2.1+ or Apache-2.0+
> +RAPTOR_LICENSE_FILES = LICENSE.txt

Since you patch configure.ac, you need 'RAPTOR_AUTORECONF = YES' here. Also, 
please add a comment explaining that we need this because we are patching 
configure.ac.

> +
> +RAPTOR_CONF_OPTS = --with-xml2-config=$(STAGING_DIR)/usr/bin/xml2-config \
> +		--with-xslt-config=$(STAGING_DIR)/usr/bin/xslt-config
> +
> +ifeq ($(BR2_PACKAGE_LIBCURL),y)
> +RAPTOR_DEPENDENCIES += libcurl
> +endif

If the configure scripts uses --with-libcurl/--without-libcurl please add this 
options to RAPTOR_CONF_OPTS as appropriate. The same goes for the rest of the 
optional dependencies below.

> +
> +ifeq ($(BR2_PACKAGE_YAJL),y)
> +RAPTOR_DEPENDENCIES += yajl
> +RAPTOR_CONF_ENV += LIBS="-lm"
> +endif
> +
> +ifeq ($(BR2_PACKAGE_YAJL),y)

Typo.

> +RAPTOR_DEPENDENCIES += icu
> +endif
> +
> +$(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2016-03-17 11:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 11:29 [Buildroot] [PATCH 1/1] raptor: new package Nitin Mendiratta
2016-03-17 11:58 ` Baruch Siach [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-02-23  4:07 Matt Weber
2016-03-06 21:19 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317115820.GI5528@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.