From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 17 Mar 2016 13:21:05 +0100 (CET) Received: from down.free-electrons.com ([37.187.137.238]:53441 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27007077AbcCQMVEao80r (ORCPT ); Thu, 17 Mar 2016 13:21:04 +0100 Received: by mail.free-electrons.com (Postfix, from userid 110) id A885E17D7; Thu, 17 Mar 2016 13:20:58 +0100 (CET) Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 78E3C468; Thu, 17 Mar 2016 13:20:58 +0100 (CET) Date: Thu, 17 Mar 2016 13:20:58 +0100 From: Alexandre Belloni To: Paul Cercueil Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, rtc-linux@googlegroups.com Subject: Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller Message-ID: <20160317122058.GE3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-4-git-send-email-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457217531-26064-4-git-send-email-paul@crapouillou.net> User-Agent: Mutt/1.5.24 (2015-08-30) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 52639 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: alexandre.belloni@free-electrons.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 05/03/2016 at 23:38:50 +0100, Paul Cercueil wrote : > + if (of_device_is_system_power_controller(pdev->dev.of_node)) { > + if (!pm_power_off) { > + /* Default: 60ms */ > + rtc->reset_pin_assert_time = 60; > + device_property_read_u32(&pdev->dev, It is probably more efficient to use of_property_read_u32 directly. Any particular reason to use device_property_read_u32? > + } else { > + dev_err(&pdev->dev, > + "Poweroff handler already present!\n"); I'm not found of that alignement, it is probably better to let the string go over 80 chars. checkpatch will not complain. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id g81si351021wmi.3.2016.03.17.05.20.59 for ; Thu, 17 Mar 2016 05:20:59 -0700 (PDT) Date: Thu, 17 Mar 2016 13:20:58 +0100 From: Alexandre Belloni To: Paul Cercueil Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller Message-ID: <20160317122058.GE3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-4-git-send-email-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1457217531-26064-4-git-send-email-paul@crapouillou.net> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 05/03/2016 at 23:38:50 +0100, Paul Cercueil wrote : > + if (of_device_is_system_power_controller(pdev->dev.of_node)) { > + if (!pm_power_off) { > + /* Default: 60ms */ > + rtc->reset_pin_assert_time = 60; > + device_property_read_u32(&pdev->dev, It is probably more efficient to use of_property_read_u32 directly. Any particular reason to use device_property_read_u32? > + } else { > + dev_err(&pdev->dev, > + "Poweroff handler already present!\n"); I'm not found of that alignement, it is probably better to let the string go over 80 chars. checkpatch will not complain. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller Date: Thu, 17 Mar 2016 13:20:58 +0100 Message-ID: <20160317122058.GE3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-4-git-send-email-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1457217531-26064-4-git-send-email-paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Cercueil Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On 05/03/2016 at 23:38:50 +0100, Paul Cercueil wrote : > + if (of_device_is_system_power_controller(pdev->dev.of_node)) { > + if (!pm_power_off) { > + /* Default: 60ms */ > + rtc->reset_pin_assert_time = 60; > + device_property_read_u32(&pdev->dev, It is probably more efficient to use of_property_read_u32 directly. Any particular reason to use device_property_read_u32? > + } else { > + dev_err(&pdev->dev, > + "Poweroff handler already present!\n"); I'm not found of that alignement, it is probably better to let the string go over 80 chars. checkpatch will not complain. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html