From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 17 Mar 2016 14:56:52 +0100 (CET) Received: from down.free-electrons.com ([37.187.137.238]:55641 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27014226AbcCQN4uPNM3e (ORCPT ); Thu, 17 Mar 2016 14:56:50 +0100 Received: by mail.free-electrons.com (Postfix, from userid 110) id B00C417C8; Thu, 17 Mar 2016 14:56:42 +0100 (CET) Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 6BE451D7; Thu, 17 Mar 2016 14:56:32 +0100 (CET) Date: Thu, 17 Mar 2016 14:56:32 +0100 From: Alexandre Belloni To: Harvey Hunt Cc: Paul Cercueil , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, rtc-linux@googlegroups.com Subject: Re: [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree Message-ID: <20160317135632.GG3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-3-git-send-email-paul@crapouillou.net> <20160317120804.GD3362@piout.net> <56EAB210.70900@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56EAB210.70900@imgtec.com> User-Agent: Mutt/1.5.24 (2015-08-30) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 52648 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: alexandre.belloni@free-electrons.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 17/03/2016 at 13:33:04 +0000, Harvey Hunt wrote : > On 17/03/16 12:08, Alexandre Belloni wrote: > >On 05/03/2016 at 23:38:49 +0100, Paul Cercueil wrote : > >>Signed-off-by: Paul Cercueil > >>--- > >> drivers/rtc/rtc-jz4740.c | 16 +++++++++++++++- > >> 1 file changed, 15 insertions(+), 1 deletion(-) > >> > >>diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c > >>index 47617bd..3914b1c 100644 > >>--- a/drivers/rtc/rtc-jz4740.c > >>+++ b/drivers/rtc/rtc-jz4740.c > >>@@ -17,6 +17,7 @@ > >> #include > >> #include > >> #include > >>+#include > >> #include > >> #include > >> #include > >>@@ -245,6 +246,13 @@ void jz4740_rtc_poweroff(struct device *dev) > >> } > >> EXPORT_SYMBOL_GPL(jz4740_rtc_poweroff); > >> > >>+static const struct of_device_id jz4740_rtc_of_match[] = { > >>+ { .compatible = "ingenic,jz4740-rtc", .data = (void *) ID_JZ4740 }, > >>+ { .compatible = "ingenic,jz4780-rtc", .data = (void *) ID_JZ4780 }, > > > >ingenic is not in Documentation/devicetree/bindings/vendor-prefixes.txt, > >you have to add it there before using it. > > Ingenic is in vendor-prefixes.txt - it was added by Commit f289cc7 > ("devicetree/bindings: add Ingenic Semiconductor vendor prefix"). > Indeed, I was looking at an old v4.1 based branch instead of master. You can forget that comment :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id 71si115346wmp.0.2016.03.17.06.56.43 for ; Thu, 17 Mar 2016 06:56:43 -0700 (PDT) Date: Thu, 17 Mar 2016 14:56:32 +0100 From: Alexandre Belloni To: Harvey Hunt Cc: Paul Cercueil , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree Message-ID: <20160317135632.GG3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-3-git-send-email-paul@crapouillou.net> <20160317120804.GD3362@piout.net> <56EAB210.70900@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <56EAB210.70900@imgtec.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 17/03/2016 at 13:33:04 +0000, Harvey Hunt wrote : > On 17/03/16 12:08, Alexandre Belloni wrote: > >On 05/03/2016 at 23:38:49 +0100, Paul Cercueil wrote : > >>Signed-off-by: Paul Cercueil > >>--- > >> drivers/rtc/rtc-jz4740.c | 16 +++++++++++++++- > >> 1 file changed, 15 insertions(+), 1 deletion(-) > >> > >>diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c > >>index 47617bd..3914b1c 100644 > >>--- a/drivers/rtc/rtc-jz4740.c > >>+++ b/drivers/rtc/rtc-jz4740.c > >>@@ -17,6 +17,7 @@ > >> #include > >> #include > >> #include > >>+#include > >> #include > >> #include > >> #include > >>@@ -245,6 +246,13 @@ void jz4740_rtc_poweroff(struct device *dev) > >> } > >> EXPORT_SYMBOL_GPL(jz4740_rtc_poweroff); > >> > >>+static const struct of_device_id jz4740_rtc_of_match[] = { > >>+ { .compatible = "ingenic,jz4740-rtc", .data = (void *) ID_JZ4740 }, > >>+ { .compatible = "ingenic,jz4780-rtc", .data = (void *) ID_JZ4780 }, > > > >ingenic is not in Documentation/devicetree/bindings/vendor-prefixes.txt, > >you have to add it there before using it. > > Ingenic is in vendor-prefixes.txt - it was added by Commit f289cc7 > ("devicetree/bindings: add Ingenic Semiconductor vendor prefix"). > Indeed, I was looking at an old v4.1 based branch instead of master. You can forget that comment :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree Date: Thu, 17 Mar 2016 14:56:32 +0100 Message-ID: <20160317135632.GG3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-3-git-send-email-paul@crapouillou.net> <20160317120804.GD3362@piout.net> <56EAB210.70900@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56EAB210.70900-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Harvey Hunt Cc: Paul Cercueil , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On 17/03/2016 at 13:33:04 +0000, Harvey Hunt wrote : > On 17/03/16 12:08, Alexandre Belloni wrote: > >On 05/03/2016 at 23:38:49 +0100, Paul Cercueil wrote : > >>Signed-off-by: Paul Cercueil > >>--- > >> drivers/rtc/rtc-jz4740.c | 16 +++++++++++++++- > >> 1 file changed, 15 insertions(+), 1 deletion(-) > >> > >>diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c > >>index 47617bd..3914b1c 100644 > >>--- a/drivers/rtc/rtc-jz4740.c > >>+++ b/drivers/rtc/rtc-jz4740.c > >>@@ -17,6 +17,7 @@ > >> #include > >> #include > >> #include > >>+#include > >> #include > >> #include > >> #include > >>@@ -245,6 +246,13 @@ void jz4740_rtc_poweroff(struct device *dev) > >> } > >> EXPORT_SYMBOL_GPL(jz4740_rtc_poweroff); > >> > >>+static const struct of_device_id jz4740_rtc_of_match[] = { > >>+ { .compatible = "ingenic,jz4740-rtc", .data = (void *) ID_JZ4740 }, > >>+ { .compatible = "ingenic,jz4780-rtc", .data = (void *) ID_JZ4780 }, > > > >ingenic is not in Documentation/devicetree/bindings/vendor-prefixes.txt, > >you have to add it there before using it. > > Ingenic is in vendor-prefixes.txt - it was added by Commit f289cc7 > ("devicetree/bindings: add Ingenic Semiconductor vendor prefix"). > Indeed, I was looking at an old v4.1 based branch instead of master. You can forget that comment :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html